From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Michal Marek <mmarek@suse.cz>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] consolidate WARN_...ONCE() static variables
Date: Thu, 5 Jan 2012 13:03:24 -0800 [thread overview]
Message-ID: <20120105130324.44949af9.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F059304020000780006A906@nat28.tlf.novell.com>
On Thu, 05 Jan 2012 11:09:40 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:
> >>> On 05.01.12 at 00:03, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Thu, 22 Dec 2011 15:53:49 +0000
> > "Jan Beulich" <JBeulich@suse.com> wrote:
> >
> >> Due to the alignment of following variables, these typically consume
> >> more than just the single byte that 'bool' requires, and as there are
> >> a few hundred instances, the cache pollution (not so much the waste of
> >> memory) sums op. Put these variables into their own section, outside
> >> of half way frequently used memory range.
> >>
>
> ...
>
> > printk_once() should also be converted. And ata_print_version_once(),
> > if it insists on continuing to exist.
>
> I disagree for those (and intentionally didn't touch printk_once();
> wasn't aware of the other) - at best this could get marked
> __read_mostly, but that's not the subject of this patch.
Confused. It is exactly the subject of the patch?
> > Also rcu_lockdep_assert().
>
> This one I mostly agree - the access is at least sitting past the
> debug_lockdep_rcu_enabled() check, albeit not in an unlikely()
> code path.
What does "unlikely" have to do with any of this?
I'm suspecting that there is some changelog crappiness going on here.
What didn't you tell us?
next prev parent reply other threads:[~2012-01-05 21:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 15:53 [PATCH] consolidate WARN_...ONCE() static variables Jan Beulich
2011-12-22 17:13 ` Arnaud Lacombe
2011-12-23 7:52 ` Jan Beulich
2012-01-04 23:03 ` Andrew Morton
2012-01-05 11:09 ` Jan Beulich
2012-01-05 21:03 ` Andrew Morton [this message]
2012-01-06 7:40 ` Jan Beulich
2012-01-06 11:03 ` Andrew Morton
2012-01-06 12:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105130324.44949af9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=JBeulich@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox