From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:57514 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506Ab2ANXTE (ORCPT ); Sat, 14 Jan 2012 18:19:04 -0500 Date: Sun, 15 Jan 2012 00:19:03 +0100 From: Michal Marek Subject: Re: [PATCH] kbuild: Fix compiler warning with assertion when calling 'fwrite' Message-ID: <20120114231902.GB19267@sepie.suse.cz> References: <87lisype1v.fsf@faui43f.informatik.uni-erlangen.de> <4EC8FF93.7010706@suse.cz> <20111123055351.GB14454@mail.gmail.com> <877h2r1hb3.fsf@faui43f.informatik.uni-erlangen.de> <20111125234253.GD14454@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111125234253.GD14454@mail.gmail.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Jean Sacren Cc: Arnaud Lacombe , Reinhard Tartler , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, amwang@redhat.com On Fri, Nov 25, 2011 at 04:42:53PM -0700, Jean Sacren wrote: > Reinhard Tartler discovered a corner case of calling xfwrite() where the > length of the string is zero. > > Arnaud Lacombe suggested to use assertion for the corner case, as > fwrite(3) is currently used: > > 1) in comment printers. Empty comment are not allowed. > 2) in a callback passed to expr_print(), where the string printed is > either NULL OR non-empty. > 3) in the lexer, auto-generated, and unused. > > I feel using assertion is a good solution: > > 1) It cleanly takes care of the above-mentioned corner case. > 2) It can be easily disabled by defining NDEBUG. > 3) It asserts xfwrite() is simply a wrapper for fwrite(). > > Reported-by: Reinhard Tartler > Signed-off-by: Arnaud Lacombe > Signed-off-by: Jean Sacren Applied to kbuild.git#kconfig. Michal