From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: linux-kbuild@vger.kernel.org
Cc: Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] scripts/config: properly report and set string options
Date: Mon, 9 Apr 2012 18:02:29 +0200 [thread overview]
Message-ID: <201204091802.29839.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20120409153006.GA28221@kroah.com>
Greg, All,
On Monday 09 April 2012 17:30:06 Greg KH wrote:
> On Mon, Apr 09, 2012 at 02:49:10PM +0200, Yann E. MORIN wrote:
> > Currently, scripts/config removes the leading double-quote from
> > string options, but leaves the trailing double-quote.
> >
> > Also, double-quotes in a string are escaped, but scripts/config
> > does not unescape those when printing
> >
> > Finally, scripts/config does not escape double-quotes when setting
> > string options.
[--SNIP--]
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: stable@vger.kernel.org
>
> How does this fit the Documentation/stable_kernel_rules.txt
Sorry, I was not aware of this list... My bad...
I'll know for next time. Thanks!
> qualification for a patch to be added to the stable releases?
I believe it qualifies because:
- it is rather trivial
- it breaks the build for users that tweak the kernel configuration from
an upper-layer (aka 'integrated') build-system, using this script which
is bundled with the kernel in the first place.
- I am a 'real people', and 'it bothers' me ;-)
OTOH, it does not qualify because:
- there is no Tested-by:
- I forgot to specify which version it should be applied to
- obviously, this fix is not yet in Linus' tree
So, please drop from -stable.
If you think that the first item, above, warrants a -stable fix, then I'll
properly re-submit once the patch is in Linus' tree.
Michal, should I re-send an updated patch whithout the CC:stable?
Sorry for the noise.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2012-04-09 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 12:49 [PATCH] scripts/config: properly report and set string options Yann E. MORIN
2012-04-09 13:22 ` Yann E. MORIN
2012-04-09 14:04 ` Andi Kleen
2012-04-09 15:30 ` Greg KH
2012-04-09 16:02 ` Yann E. MORIN [this message]
2012-04-10 8:57 ` Michal Marek
2012-04-10 13:57 ` Jonathan Nieder
2012-04-10 23:07 ` Yann E. MORIN
2012-04-11 1:33 ` Jonathan Nieder
2012-04-19 21:07 ` Yann E. MORIN
2012-05-15 22:14 ` Michal Marek
2012-05-09 21:27 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204091802.29839.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=andi@firstfloor.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox