From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: linux-kbuild@vger.kernel.org
Cc: Andi Kleen <andi@firstfloor.org>, Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH 1/3] scripts/config: be case-sensitive on config option symbols
Date: Thu, 7 Jun 2012 20:06:24 +0200 [thread overview]
Message-ID: <201206072006.24915.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20120607025417.GJ27374@one.firstfloor.org>
Andi, All,
On Thursday 07 June 2012 04:54:17 Andi Kleen wrote:
> > With this patch, if the KCONFIG_CASE environment variable is set to (with
> > no quotes):
> > - 'upper': force symbols to upper-case
> > - 'lower': force symbols to lower-case
>
> That's ugly. How about a emacs style heuristic. When the config symbol
> is mixed case do not change the symbol?
Such a heuristic would still break with some of the symbols used in the Linux
tree:
./arch/powerpc/platforms/Kconfig.cputype:config 6xx
./arch/powerpc/platforms/Kconfig.cputype:config 8xx
./arch/powerpc/platforms/Kconfig.cputype:config 4xx
Not to say about other projects which may use lower-case only symbols.
What about adding an option to keep the case as-is:
--keep-case|-k Keep symbol's case (dont' upper-case it)
Ideally, we could also add (I'd make a separate patch for that):
--upper-case|-U Upper-case the symbol
--lower-case|-l Lower-case the symbol
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2012-06-07 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 22:29 [PATCH 1/3] scripts/config: be case-sensitive on config option symbols Yann E. MORIN
2012-06-06 22:29 ` [PATCH 2/3] scripts/config: allow alternate prefix to config option symbol Yann E. MORIN
2012-06-06 22:29 ` [PATCH 3/3] scripts/config: add option to undef a symbol Yann E. MORIN
2012-06-07 2:54 ` [PATCH 1/3] scripts/config: be case-sensitive on config option symbols Andi Kleen
2012-06-07 18:06 ` Yann E. MORIN [this message]
2012-06-07 18:17 ` Andi Kleen
2012-06-07 21:49 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206072006.24915.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=andi@firstfloor.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox