From: Ben Hutchings <ben@decadent.org.uk>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Andi Kleen <andi@firstfloor.org>
Cc: pkg-sysvinit-devel@lists.alioth.debian.org,
debian-devel@lists.debian.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: (fwd) make tar*-pkg considered dangerous
Date: Wed, 12 Sep 2012 21:39:21 +0100 [thread overview]
Message-ID: <20120912203921.GY29217@decadent.org.uk> (raw)
In-Reply-To: <20120912161154.GB3289@khazad-dum.debian.net>
On Wed, Sep 12, 2012 at 01:11:54PM -0300, Henrique de Moraes Holschuh wrote:
> I am forwarding this as a remider that, should we ever get to the point of
> moving around /lib or /usr/lib, /sbin or /usr/sbin, and /bin or /usr/sbin,
> as well as any other such trunks, we really ought to consider whether we
> should be using symlinks or bind mounts [where possible] for such moves.
>
> Also, just in case, Debian users are gently reminded that there are less
> unsavory methods of packing custom kernel builds for later use in Debian
> boxes, including the Linux upstream "deb-pkg" make target (dpkg is a lot
> smarter than "tar"), and the make-kpkg command provided by the
> kernel-package Debian package (which IMHO tends to produce better kernel
> .deb packages than the upstream "deb-pkg" make target.
kernel-package is effectively unmaintained, so please don't recommend
its use unless you intend to rectify that.
> ----- Forwarded message from Andi Kleen <andi@firstfloor.org> -----
> Date: Wed, 12 Sep 2012 05:16:46 +0200
> From: Andi Kleen <andi@firstfloor.org>
> To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
> Subject: make tar*-pkg considered dangerous
>
> Hi,
>
> We've had some incidents with people destroying Fedore 17 installs
> (to the point of reinstall) by installing a kernel tarball generated with
> make tar*-pkg
>
> The problem is that the tarball includes /lib/{modules,firmware},
> but on FC17 /lib is a symlink. tar when it unpacks the tarball
> replaces the symlink with the directory.
[...]
Presumably the tarball also contains an entry for the directory lib,
and that (not the subdirectory entries) triggers tar to replace the
symlink. So this can be fixed by only including
lib/{modules,firmware} in the tarball, not lib.
A quick experiment under F16 (tar 1.26) supports this.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
next prev parent reply other threads:[~2012-09-12 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 3:16 make tar*-pkg considered dangerous Andi Kleen
2012-09-12 16:43 ` Zdenek Kaspar
[not found] ` <20120912161154.GB3289@khazad-dum.debian.net>
2012-09-12 20:39 ` Ben Hutchings [this message]
2012-09-19 11:58 ` Thorsten Glaser
2012-09-25 22:17 ` [PATCH] kbuild: Do not package /boot and /lib in make tar-pkg Michal Marek
2012-09-26 16:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912203921.GY29217@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=andi@firstfloor.org \
--cc=debian-devel@lists.debian.org \
--cc=hmh@hmh.eng.br \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pkg-sysvinit-devel@lists.alioth.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox