* [PATCH] kbuild: Remove reference to uninitialised variable
@ 2012-10-15 12:49 Charles Keepax
2012-11-20 10:25 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2012-10-15 12:49 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, linux-kernel, patches
Verbose output variable is unnecessary because the command's echo is
already surpressed. Additionally because the block defines skip-makefile
the variable Q is not defined within the makefile, which can cause
problems if Q is defined in the users environment.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index a687963..2a7be73 100644
--- a/Makefile
+++ b/Makefile
@@ -124,7 +124,7 @@ $(if $(KBUILD_OUTPUT),, \
PHONY += $(MAKECMDGOALS) sub-make
$(filter-out _all sub-make $(CURDIR)/Makefile, $(MAKECMDGOALS)) _all: sub-make
- $(Q)@:
+ @:
sub-make: FORCE
$(if $(KBUILD_VERBOSE:1=),@)$(MAKE) -C $(KBUILD_OUTPUT) \
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: Remove reference to uninitialised variable
2012-10-15 12:49 [PATCH] kbuild: Remove reference to uninitialised variable Charles Keepax
@ 2012-11-20 10:25 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2012-11-20 10:25 UTC (permalink / raw)
To: Charles Keepax; +Cc: linux-kbuild, linux-kernel, patches
On Mon, Oct 15, 2012 at 01:49:12PM +0100, Charles Keepax wrote:
> Verbose output variable is unnecessary because the command's echo is
> already surpressed. Additionally because the block defines skip-makefile
> the variable Q is not defined within the makefile, which can cause
> problems if Q is defined in the users environment.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Applied to kbuild.git#kbuild, thanks.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-20 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-15 12:49 [PATCH] kbuild: Remove reference to uninitialised variable Charles Keepax
2012-11-20 10:25 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).