* Re: [menuconfig] build failure.
[not found] <201210162049.HIC43747.OOtOJHFFFQMVSL@I-love.SAKURA.ne.jp>
@ 2012-10-16 12:58 ` Benjamin Poirier
2012-10-17 22:47 ` Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Benjamin Poirier @ 2012-10-16 12:58 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: mmarek, linux-kbuild
Michal, do you think we're better off:
* copying the CIRCLEQ macros from sys/queue.h (about 30 lines needed,
bsd licenced)
* switching over to kernel-style linked lists using:
* a copy of tools/firewire/list.h
* #include "../../../include/linux/list.h" like perf does in
tools/perf/util/include/linux/list.h
-Benjamin
On 2012/10/16 20:49, Tetsuo Handa wrote:
> Hello.
>
> Commit 95ac9b3b "menuconfig: Assign jump keys per-page instead of globally"
> broke menuconfig on legacy environment (Debian Sarge). oops...
>
> # make menuconfig
> HOSTCC scripts/kconfig/mconf.o
> scripts/kconfig/mconf.c: In function `update_text':
> scripts/kconfig/mconf.c:326: warning: implicit declaration of function `CIRCLEQ_FOREACH'
> scripts/kconfig/mconf.c:326: error: `entries' undeclared (first use in this function)
> scripts/kconfig/mconf.c:326: error: (Each undeclared identifier is reported only once
> scripts/kconfig/mconf.c:326: error: for each function it appears in.)
> scripts/kconfig/mconf.c:326: error: syntax error before '{' token
> scripts/kconfig/mconf.c:333: error: `header' undeclared (first use in this function)
> scripts/kconfig/mconf.c: At top level:
> scripts/kconfig/mconf.c:343: error: syntax error before '}' token
> scripts/kconfig/mconf.c: In function `search_conf':
> scripts/kconfig/mconf.c:378: warning: implicit declaration of function `CIRCLEQ_HEAD_INITIALIZER'
> scripts/kconfig/mconf.c:378: error: invalid initializer
> make[1]: *** [scripts/kconfig/mconf.o] Error 1
> make: *** [menuconfig] Error 2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [menuconfig] build failure.
2012-10-16 12:58 ` [menuconfig] build failure Benjamin Poirier
@ 2012-10-17 22:47 ` Yann E. MORIN
2012-10-19 14:46 ` Tetsuo Handa
2012-10-19 15:17 ` Michal Marek
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2012-10-17 22:47 UTC (permalink / raw)
To: linux-kbuild; +Cc: Benjamin Poirier, Tetsuo Handa, mmarek
Michal, Tetsuo, Benjamin, All,
On Tuesday 16 October 2012 Benjamin Poirier wrote:
> Michal, do you think we're better off:
> * copying the CIRCLEQ macros from sys/queue.h (about 30 lines needed,
> bsd licenced)
> * switching over to kernel-style linked lists using:
> * a copy of tools/firewire/list.h
> * #include "../../../include/linux/list.h" like perf does in
> tools/perf/util/include/linux/list.h
>
> -Benjamin
>
> On 2012/10/16 20:49, Tetsuo Handa wrote:
> > Hello.
> >
> > Commit 95ac9b3b "menuconfig: Assign jump keys per-page instead of globally"
> > broke menuconfig on legacy environment (Debian Sarge). oops...
It also breaks building on Cygwin, because Cygwin does not have the
CIRCLEQ macros in sys/queue.h (it does not even have it all).
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [menuconfig] build failure.
2012-10-16 12:58 ` [menuconfig] build failure Benjamin Poirier
2012-10-17 22:47 ` Yann E. MORIN
@ 2012-10-19 14:46 ` Tetsuo Handa
2012-10-19 15:17 ` Michal Marek
2 siblings, 0 replies; 4+ messages in thread
From: Tetsuo Handa @ 2012-10-19 14:46 UTC (permalink / raw)
To: bpoirier; +Cc: mmarek, linux-kbuild
Benjamin Poirier wrote:
> Michal, do you think we're better off:
> * copying the CIRCLEQ macros from sys/queue.h (about 30 lines needed,
> bsd licenced)
Oops, I didn't notice that sys/queue.h is bsd licenced.
Then, how can we use missing CIRCLEQ macros (from gpl licenced
scripts/kconfig/ files) which is not defined inside bsd licenced
old sys/queue.h but is defined inside bsd licenced new sys/queue.h ?
Is it OK to copy these missing CIRCLEQ macros from bsd licenced new
sys/queue.h to gpl licenced scripts/kconfig/expr.h ?
Or, create a separate file containing only missing CIRCLEQ macros
and #include it (provided that userland tools included in linux's
tarball accepts bsd licenced file)?
> * switching over to kernel-style linked lists using:
> * a copy of tools/firewire/list.h
> * #include "../../../include/linux/list.h" like perf does in
> tools/perf/util/include/linux/list.h
>
> -Benjamin
>
> On 2012/10/16 20:49, Tetsuo Handa wrote:
> > Hello.
> >
> > Commit 95ac9b3b "menuconfig: Assign jump keys per-page instead of globally"
> > broke menuconfig on legacy environment (Debian Sarge). oops...
> >
> > # make menuconfig
> > HOSTCC scripts/kconfig/mconf.o
> > scripts/kconfig/mconf.c: In function `update_text':
> > scripts/kconfig/mconf.c:326: warning: implicit declaration of function `CIRCLEQ_FOREACH'
> > scripts/kconfig/mconf.c:326: error: `entries' undeclared (first use in this function)
> > scripts/kconfig/mconf.c:326: error: (Each undeclared identifier is reported only once
> > scripts/kconfig/mconf.c:326: error: for each function it appears in.)
> > scripts/kconfig/mconf.c:326: error: syntax error before '{' token
> > scripts/kconfig/mconf.c:333: error: `header' undeclared (first use in this function)
> > scripts/kconfig/mconf.c: At top level:
> > scripts/kconfig/mconf.c:343: error: syntax error before '}' token
> > scripts/kconfig/mconf.c: In function `search_conf':
> > scripts/kconfig/mconf.c:378: warning: implicit declaration of function `CIRCLEQ_HEAD_INITIALIZER'
> > scripts/kconfig/mconf.c:378: error: invalid initializer
> > make[1]: *** [scripts/kconfig/mconf.o] Error 1
> > make: *** [menuconfig] Error 2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [menuconfig] build failure.
2012-10-16 12:58 ` [menuconfig] build failure Benjamin Poirier
2012-10-17 22:47 ` Yann E. MORIN
2012-10-19 14:46 ` Tetsuo Handa
@ 2012-10-19 15:17 ` Michal Marek
2 siblings, 0 replies; 4+ messages in thread
From: Michal Marek @ 2012-10-19 15:17 UTC (permalink / raw)
To: Benjamin Poirier; +Cc: Tetsuo Handa, linux-kbuild, Arnaud Lacombe
On 16.10.2012 14:58, Benjamin Poirier wrote:
> Michal, do you think we're better off:
> * copying the CIRCLEQ macros from sys/queue.h (about 30 lines needed,
> bsd licenced)
> * switching over to kernel-style linked lists using:
> * a copy of tools/firewire/list.h
> * #include "../../../include/linux/list.h" like perf does in
> tools/perf/util/include/linux/list.h
I did not know that linux/list.h can be used by userspace without
modifications. But I guess such dependency would still be inconvenient
for people who are using kconfig externally. Arnaud, what do you think?
So I think that the next-best thing is to copy tools/firewire/list.h.
That way, we avoid all the ifdefs.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-19 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201210162049.HIC43747.OOtOJHFFFQMVSL@I-love.SAKURA.ne.jp>
2012-10-16 12:58 ` [menuconfig] build failure Benjamin Poirier
2012-10-17 22:47 ` Yann E. MORIN
2012-10-19 14:46 ` Tetsuo Handa
2012-10-19 15:17 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox