From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: linux-kbuild@vger.kernel.org
Cc: Wang YanQing <udknight@gmail.com>,
mmarek@suse.cz, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net, bp@alien8.de, sakiwit@gmail.com,
lacombar@gmail.com, lucas.demarchi@profusion.mobi, dave@gnu.org,
paul.gortmaker@windriver.com, crquan@gmail.com, bpoirier@suse.de
Subject: Re: [PATCH] lxdialog:inputbox: Fix can't change selected button with Left/Right when input box selected
Date: Sun, 2 Dec 2012 18:32:43 +0100 [thread overview]
Message-ID: <201212021832.44326.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20121202163509.GB20796@udknight>
Wang, All,
On Sunday 02 December 2012 Wang YanQing wrote:
> inputbox code don't support use Left/Right to change input
> position in the input box, so it use continue to skip them
> when input key is Left/Right, but use break for Up/Down, so
> we can change selected button with Up/Down but we can't do it
> with Left/Right key when input box selected.
> This patch fix it.
Although I do understand the motivation behind your change, may I suggest
that left/right are used to navigate *inside* the input field, so it is
possible to modify the text in place?
The nconf frontend allows editing text in place, so I find it disturbing
not to be able to do it in mconf.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2012-12-02 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 16:35 [PATCH] lxdialog:inputbox: Fix can't change selected button with Left/Right when input box selected Wang YanQing
2012-12-02 17:32 ` Yann E. MORIN [this message]
2012-12-03 4:47 ` Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201212021832.44326.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=bp@alien8.de \
--cc=bpoirier@suse.de \
--cc=crquan@gmail.com \
--cc=dave@gnu.org \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mmarek@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=sakiwit@gmail.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox