From: Adam Lee <adam8157@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kconfig: fix the failure of `make rpm-pkg` after localversion file changed
Date: Mon, 18 Feb 2013 11:08:29 +0800 [thread overview]
Message-ID: <20130218030829.GA6690@adam-laptop> (raw)
In-Reply-To: <1352014361-21159-1-git-send-email-adam8157@gmail.com>
On Sun, Nov 04, 2012 at 03:32:41PM +0800, Adam Lee wrote:
> `make rpm-pkg` and `make binrpm-pkg` will write $KERNELRELEASE into rpm
> spec files which don't depend on localversion file now. So, the
> unchanged spec files will cause failure after localversion file changed.
>
> I added the localversion file into the dependencies of spec files.
> Because that file is not necessary, I made it a empty target, so its
> last-modification time will be checked by Make only when it exists.
>
> Signed-off-by: Adam Lee <adam8157@gmail.com>
> ---
> scripts/package/Makefile | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Hi, Michal
Any comment about my fix?
reproduce steps:
1, make rpm-pkg
2, change localversion
3, make rpm-pkg
--
Regards,
Adam Lee
http://adam8157.info
prev parent reply other threads:[~2013-02-18 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 7:32 [PATCH] kconfig: fix the failure of `make rpm-pkg` after localversion file changed Adam Lee
2013-02-18 3:08 ` Adam Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218030829.GA6690@adam-laptop \
--to=adam8157@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox