From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: linux-kbuild@vger.kernel.org
Cc: jlec@gentoo.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Use config scripts to detect ncurses libs for nconfig
Date: Wed, 27 Feb 2013 20:02:59 +0100 [thread overview]
Message-ID: <201302272002.59833.yann.morin.1998@free.fr> (raw)
In-Reply-To: <1361988458-18486-2-git-send-email-jlec@gentoo.org>
Justin, All,
On Wednesday 27 February 2013 jlec@gentoo.org wrote:
> From: Justin Lecher <jlec@gentoo.org>
>
> When building ncurses with --with-termlib several symbols get moved from
> libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
> additionally needs to link with libtinfo.so.
>
> Ncurses provides a config script (ncurses5-config) to assist finding ncurses.
> This patch makes use of it to detect the necessary libs for linking of the
> ncurses nconfig dialog.
>
> Signed-off-by: Justin Lecher <jlec@gentoo.org>
Ditto for the subject, as for your previous patch.
> ---
> scripts/kconfig/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 3091794..7ddbf98 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -216,7 +216,7 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
>
> HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
>
> -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses
> +HOSTLOADLIBES_nconf = -lmenu -lpanel `ncursesw5-config --libs 2>/dev/null || ncurses5-config --libs 2>/dev/null`
Long-line. Also, this expands the `...` in the shell, not in the Makefile.
I'd rather have the expansion be done by the Makefile:
HOSTLOADLIBES_nconf = -lmenu -lpanel
HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \
|| ncurses5-config --libs 2>/dev/null )
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-02-27 19:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 18:07 [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig jlec
2013-02-27 18:07 ` [PATCH 2/2] Use config scripts to detect ncurses libs for nconfig jlec
2013-02-27 19:02 ` Yann E. MORIN [this message]
2013-02-28 9:48 ` justin
2013-02-28 17:58 ` Yann E. MORIN
2013-02-27 18:37 ` [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig Yann E. MORIN
2013-02-28 9:35 ` justin
2013-02-28 18:08 ` Yann E. MORIN
2013-02-28 21:31 ` justin
2013-02-28 21:35 ` Yann E. MORIN
2013-02-28 21:38 ` justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302272002.59833.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=jlec@gentoo.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox