From: maximilian attems <max@stro.at>
To: Michal Marek <mmarek@suse.cz>
Cc: Sedat Dilek <sedat.dilek@googlemail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution
Date: Thu, 28 Feb 2013 07:32:35 +0000 [thread overview]
Message-ID: <20130228073235.GP10026@vostochny.stro.at> (raw)
In-Reply-To: <512E1061.3030007@suse.cz>
On Wed, Feb 27, 2013 at 02:55:45PM +0100, Michal Marek wrote:
> Sorry I missed this series. Max, can you have a look? I don't know the
> policies for debian package changelogs. The full series is at
> http://lkml.indiana.edu/hypermail/linux/kernel/1204.2/index.html#04252,
> but the remaining two patches are obvious.
the two remaining ones are trivial, should have pushed them a long time
ago and will do so this weekend in a combined version going up to 2013
(sitting in my queue to send).
> On 24.4.2012 00:16, Sedat Dilek wrote:
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> > ---
> > scripts/package/builddeb | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> > index eee5f8e..f5b56ac 100644
> > --- a/scripts/package/builddeb
> > +++ b/scripts/package/builddeb
> > @@ -172,9 +172,22 @@ else
> > fi
> > maintainer="$name <$email>"
> >
> > +# Try to determine distribution
> > +if [ -e $(which lsb_release) ]; then
> > + codename=$(lsb_release --codename --short)
> > + if [ "$codename" != "" ]; then
> > + distribution=$codename
> > + else
> > + distribution="UNRELEASED"
> > + echo "WARNING: The distribution could NOT be determined!"
> > + fi
> > +else
> > + echo "HINT: Install lsb_release binary, this helps to identify your distribution!"
> > +fi
> > +
> > # Generate a simple changelog template
> > cat <<EOF > debian/changelog
> > -linux-upstream ($packageversion) unstable; urgency=low
> > +linux-upstream ($packageversion) $distribution; urgency=low
> >
> > * Custom built Linux kernel.
this is pretty useless.
Nack, in adding a this additional lsb dep.
I know it should be installed by default, but in practise it is often not.
If you'd really care about the changelog you'd generate it out of your
git repo with Debian's git dch in order to have something meaningful.
--
maks
next prev parent reply other threads:[~2013-02-28 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 22:16 [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution Sedat Dilek
2012-04-23 22:16 ` [PATCH 2/3] kbuild, deb-pkg: Bump year in debian/copyright file Sedat Dilek
2012-04-23 22:16 ` [PATCH 3/3] kbuild, deb-pkg: Update git repository URL " Sedat Dilek
2013-02-27 13:55 ` [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution Michal Marek
2013-02-27 14:09 ` Sedat Dilek
2013-02-27 20:58 ` Thorsten Glaser
2013-02-28 7:32 ` maximilian attems [this message]
2013-02-28 9:45 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228073235.GP10026@vostochny.stro.at \
--to=max@stro.at \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sedat.dilek@gmail.com \
--cc=sedat.dilek@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox