Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Michal Marek <mmarek@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Tejun Heo <tj@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH RFC 1/5] kconfig: implement weak reverse-dependencies
Date: Thu, 21 Mar 2013 12:43:08 +0100	[thread overview]
Message-ID: <20130321114307.GA6716@netboy.at.omicron.at> (raw)
In-Reply-To: <514AE9A3.5090209@openvz.org>

On Thu, Mar 21, 2013 at 03:06:11PM +0400, Konstantin Khlebnikov wrote:
> 
> As I see this technology requires special dedicated server in the local
> network, thus it's unusable in most situations. But it starts working
> without any actions from the user (please fix me if I'm wrong).

Perhaps you don't have a very clear picture of how this PTP stuff
works. Even when the PHC and time stamping code is compiled in, it
does *not* start working unless the end user turns it on, via the
SIOCSHWTSTAMP and SO_TIMESTAMPING options.

See: Documentation/networking/timestamping.txt
     Documentation/ptp/ptp.txt
 
> Thus this code enables some rarely used parts of hardware.
> After seeing several weird bugs in ethernet devices I prefer to
> keep unused/unwanted features off.

Just compiling drivers into kernel does not really change the behavior
of the hardware. The only drawback I know of is that it adds (minimal)
overhead into the packet processing paths, but that is a software
issue.

I don't mean to start a big discussion here. The question of whether
to have PHC support a compile time option should be discussed on the
netdev list (added on CC just in case).

Thanks,
Richard



      reply	other threads:[~2013-03-21 11:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21  8:22 [PATCH RFC 1/5] kconfig: implement weak reverse-dependencies Konstantin Khlebnikov
2013-03-21  8:23 ` [PATCH RFC 2/5] kconfig: regen parser Konstantin Khlebnikov
2013-03-21  8:23 ` [PATCH RFC 3/5] kconfig: simplity linking cross-module glue objects Konstantin Khlebnikov
2013-03-21  8:23 ` [PATCH RFC 4/5] ptp: add stub function for ptp_clock_index() Konstantin Khlebnikov
2013-03-21  8:23 ` [PATCH RFC 5/5] e1000e: make PTP clock optional Konstantin Khlebnikov
2013-03-21 10:22 ` [PATCH RFC 1/5] kconfig: implement weak reverse-dependencies Richard Cochran
2013-03-21 11:06   ` Konstantin Khlebnikov
2013-03-21 11:43     ` Richard Cochran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321114307.GA6716@netboy.at.omicron.at \
    --to=richardcochran@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=khlebnikov@openvz.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox