From: Michal Marek <mmarek@suse.cz>
To: Bin Wang <wbin00@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT
Date: Mon, 8 Apr 2013 13:05:32 +0200 [thread overview]
Message-ID: <20130408110532.GA3291@sepie.suse.cz> (raw)
In-Reply-To: <CAD_32VUREUgiBt2ScK31ig-p8282g7VZta+Q6Fq0pkEaDGxm+A@mail.gmail.com>
On Thu, Mar 14, 2013 at 09:30:32AM +0800, Bin Wang wrote:
> Hi, Michal
>
> Is there any comments on this?
Sorry, I missed this one. I applied it to kbuild.git#misc now.
Michal
>
> 2013/2/25 Bin Wang <wbin00@gmail.com>:
> > KBUILD_OUTPUT is always empty here, so it is useless to test it. But
> > while use O=.., objtree and srctree will be different. I compare them
> > instead.
> >
> > Signed-off-by: Bin Wang <wbin00@gmail.com>
> > ---
> > scripts/package/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> > index 87bf080..d7b3285 100644
> > --- a/scripts/package/Makefile
> > +++ b/scripts/package/Makefile
> > @@ -36,7 +36,7 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile
> > $(CONFIG_SHELL) $(MKSPEC) > $@
> >
> > rpm-pkg rpm: $(objtree)/kernel.spec FORCE
> > - @if test -n "$(KBUILD_OUTPUT)"; then \
> > + @if test "$(objtree)" != "$(srctree)"; then \
> > echo "Building source + binary RPM is not possible outside the"; \
> > echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
> > echo "binrpm-pkg target instead."; \
> > --
> > 1.8.1.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-04-08 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 3:05 [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT Bin Wang
2013-03-14 1:30 ` Bin Wang
2013-04-08 11:05 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408110532.GA3291@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wbin00@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox