From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Rob Landley <rob@landley.net>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Benjamin Poirier <bpoirier@suse.de>
Subject: Re: [PATCH 1/1] kconfig: fix lists definition for C++
Date: Tue, 30 Apr 2013 00:30:54 +0200 [thread overview]
Message-ID: <20130429223054.GB31039@free.fr> (raw)
In-Reply-To: <1367272454.18069.191@driftwood>
Rob, All,
On Mon, Apr 29, 2013 at 04:54:14PM -0500, Rob Landley wrote:
> On 04/29/2013 02:28:07 PM, Randy Dunlap wrote:
> >On 04/29/13 10:59, Yann E. MORIN wrote:
> >> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >>
> >> The C++ compiler is more strict in that it refuses to assign
> >> a void* to a struct list_head*.
>
> Given that the code _isn't_ C++ (because C is not a subset of C++ but a
> separate langauge in its own right where "throw" is a legitimate variable
> name and so on), how is this an issue?
It's an issue because the xconfig frontends is qconf, which as the name
implies is using Qt, which *is* C++, and includes list.h.
So, list.h is included by both by C and C++ code.
So yes, list.h can be compiled by a C++ compiler.
Now, granted: list.h should all be enclosed in:
ifdef __cpluplus
extern "C" {
endif
...
ifdef __cpluplus
}
endif
Was that the fix you were suggesting between the lines? ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-04-29 22:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 17:59 [pull request] Pull request for branch yem-kconfig-for-next Yann E. MORIN
2013-04-29 17:59 ` [PATCH 1/1] kconfig: fix lists definition for C++ Yann E. MORIN
2013-04-29 19:28 ` Randy Dunlap
2013-04-29 21:54 ` Rob Landley
2013-04-29 22:30 ` Yann E. MORIN [this message]
2013-04-29 22:57 ` Rob Landley
2013-05-02 8:48 ` [pull request] Pull request for branch yem-kconfig-for-next Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429223054.GB31039@free.fr \
--to=yann.morin.1998@free.fr \
--cc=bpoirier@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox