From: Ian Kumlien <pomac@vapor.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kbuild@vger.kernel.org, mmarek@suse.cz
Subject: Re: Silent failure when missing bc
Date: Thu, 2 May 2013 20:28:50 +0200 [thread overview]
Message-ID: <20130502182850.GF6335@pomac.netswarm.net> (raw)
In-Reply-To: <51829070.4070305@zytor.com>
On Thu, May 02, 2013 at 09:12:32AM -0700, H. Peter Anvin wrote:
> On 05/02/2013 07:44 AM, Ian Kumlien wrote:
> > Hi,
> >
> > A dependency on bc was added at some point during the 3.9 development.
> >
> > My machines runs a git forest which contains both stable and Torvalds
> > mainline. So any kernel version is only a:
> > git fetch --all && git checkout <tag> away
> >
> > When switching from v3.8.5 to v3.9-rc7 i ran in to a odd thing.
> >
> > It seemed to build fine, make install and modules_install was all fine
> > as well but rebooting revealed that 3.8.5 had been installed again
> > instead.
>
> Are you *sure* that the build didn't stop and you just didn't notice it?
> That is what the above sounds like. Keep in mind that in a parallel
> build there can be quite a few lines of output after the *** failure line...
Damn it, i didn't see it in the 30+ line window, but yes there is a
error message.
Must have been more tired than i thought...
> > Doing make clean and rebuilding revealed that I was missing bc ;)
> >
> > I have tried to find exactly where it's run since then, i have found the
> > cmd_bc section but not found what triggers it... Due to lack of time and
> > energy, I hearby report this bug!
> >
> > This is about as far as i got:
> > kernel/Makefile:135:quiet_cmd_bc = BC $@
> > kernel/Makefile:136: cmd_bc = bc -q $(filter-out FORCE,$^) > $@
> >
> > Is there any detaled information and or instructions on kbuild btw?
>
> The disconcerting thing here, of course, is if the build would have
> looked like it completed without the file actually being generated. It
> should have failed either to generate the file, or it should have
> produced an empty header which would have caused a failure further down
> the line...
Imho it should have had bc as a dependency and failed to run that step.
Ie instead of "/bin/sh: bc: command not found"
Do we know which tools we need? could we add them as "make
dependencies"?
> -hpa
>
next prev parent reply other threads:[~2013-05-02 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 14:44 Silent failure when missing bc Ian Kumlien
2013-05-02 16:12 ` H. Peter Anvin
2013-05-02 18:28 ` Ian Kumlien [this message]
2013-05-02 19:28 ` H. Peter Anvin
2013-05-02 20:25 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502182850.GF6335@pomac.netswarm.net \
--to=pomac@vapor.com \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox