* [PATCH] Makefile: make sparse (CHECK) user-selectable
@ 2013-05-08 15:23 Phil Carmody
2013-05-08 17:44 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Phil Carmody @ 2013-05-08 15:23 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild, linux-kernel, Phil Carmody
I've got a tweaked version as well as the system default,
so make the sparse binary that's run user-selectable.
Signed-off-by: Phil Carmody <pc+lkml@asdf.org>
---
Makefile | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index a3a834b..e7a4851 100644
--- a/Makefile
+++ b/Makefile
@@ -338,7 +338,9 @@ GENKSYMS = scripts/genksyms/genksyms
INSTALLKERNEL := installkernel
DEPMOD = /sbin/depmod
PERL = perl
-CHECK = sparse
+ifndef CHECK
+ CHECK = sparse
+endif
CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
-Wbitwise -Wno-return-void $(CF)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: make sparse (CHECK) user-selectable
2013-05-08 15:23 [PATCH] Makefile: make sparse (CHECK) user-selectable Phil Carmody
@ 2013-05-08 17:44 ` Randy Dunlap
2013-05-10 2:37 ` Phil Carmody
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2013-05-08 17:44 UTC (permalink / raw)
To: Phil Carmody; +Cc: mmarek, linux-kbuild, linux-kernel
On 05/08/13 08:23, Phil Carmody wrote:
> I've got a tweaked version as well as the system default,
> so make the sparse binary that's run user-selectable.
>
I'm confused about why this patch is necessary since I already do
$ make O=builddir CHECK=/path/to/sparse all
> Signed-off-by: Phil Carmody <pc+lkml@asdf.org>
> ---
> Makefile | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a3a834b..e7a4851 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -338,7 +338,9 @@ GENKSYMS = scripts/genksyms/genksyms
> INSTALLKERNEL := installkernel
> DEPMOD = /sbin/depmod
> PERL = perl
> -CHECK = sparse
> +ifndef CHECK
> + CHECK = sparse
> +endif
>
> CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
> -Wbitwise -Wno-return-void $(CF)
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: make sparse (CHECK) user-selectable
2013-05-08 17:44 ` Randy Dunlap
@ 2013-05-10 2:37 ` Phil Carmody
0 siblings, 0 replies; 3+ messages in thread
From: Phil Carmody @ 2013-05-10 2:37 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Phil Carmody, mmarek, linux-kbuild, linux-kernel
On 08/05/13 10:44 -0700, Randy Dunlap wrote:
> On 05/08/13 08:23, Phil Carmody wrote:
> > I've got a tweaked version as well as the system default,
> > so make the sparse binary that's run user-selectable.
> >
>
> I'm confused about why this patch is necessary since I already do
>
> $ make O=builddir CHECK=/path/to/sparse all
Ach, OK. I was presuming that I should be able to select my sparse
in the same way that I select my cross compiler, namely in the ENV.
CROSS_COMPILE=whatever- CHECK=/my/sparse make C=1
Doctor - it hurts when I do >this<, ouch.
Well, don't do that then!
Phil
--
"In a world of magnets and miracles"
-- Insane Clown Posse, Miracles, 2009. Much derided.
"Magnets, how do they work"
-- Pink Floyd, High Hopes, 1994. Lauded as lyrical geniuses.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-10 2:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-08 15:23 [PATCH] Makefile: make sparse (CHECK) user-selectable Phil Carmody
2013-05-08 17:44 ` Randy Dunlap
2013-05-10 2:37 ` Phil Carmody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox