From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:61699 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717Ab3F1RTO (ORCPT ); Fri, 28 Jun 2013 13:19:14 -0400 Received: by mail-wi0-f170.google.com with SMTP id ey16so2036082wid.3 for ; Fri, 28 Jun 2013 10:19:13 -0700 (PDT) Date: Fri, 28 Jun 2013 19:19:09 +0200 From: "Yann E. MORIN" Subject: Re: [PATCH] Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG" Message-ID: <20130628171908.GD3165@free.fr> References: <20130625205836.GB14074@free.fr> <1372196264-3407-1-git-send-email-yann.morin.1998@free.fr> <20130626134852.GA25921@sepie.suse.cz> <20130626214425.GA3223@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Sedat Dilek Cc: Michal Marek , linux-kbuild@vger.kernel.org, Sam Ravnborg Sedat, All, On 2013-06-27 08:23 +0200, Sedat Dilek spake thusly: > On Wed, Jun 26, 2013 at 11:44 PM, Yann E. MORIN wrote: > > Michal, All, > > > > On 2013-06-26 15:48 +0200, Michal Marek spake thusly: > >> On Tue, Jun 25, 2013 at 11:37:44PM +0200, Yann E. MORIN wrote: > >> > From: "Yann E. MORIN" > >> > > >> > This reverts commit 8357b48549e17b3e4e402c7f977b65708922e60f. > >> > > >> > It breaks more stuff than it fixes. > >> > >> Thanks, I applied it to kbuild.git#kconfig, after verifying that the > >> issue is gone. > > > > Yes, thanks. I'm sorry this second attempt was a (slightly different!) > > failure again. :-( [--SNIP--] > Can you please write up some cooler changelog next time why this > revert was done? > In one of your emails you did some nice analysis. > Such informations belong IMHO into the revert's changelog. Yes, you are right, I'll do next time I'll have to send a revert patch (which I hope not to have to for some time! ;-) ) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'