Re: [PATCH 13/15] kconfig/[mn]conf: make it explicit in the search box that a regexp is possible

Jean Delvare
2013-07-08T11:25:39Z

Hi Yann,

Le Monday 24 June 2013 à 20:11 +0200, Yann E. MORIN a écrit :
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Michal Marek <mmarek@suse.cz>
> ---
> scripts/kconfig/mconf.c | 2 +-
> scripts/kconfig/nconf.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 6ee4aae..18d3dc9 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -401,7 +401,7 @@ static void search_conf(void)
> struct subtitle_part stpart;
>
> title = str_new();
> - str_printf( &title, _("Enter %s (sub)string to search for "
> + str_printf( &title, _("Enter %s (sub)string or regexp to search for "
> "(with or without \"%s\")"), CONFIG_, CONFIG_);

While clearer, this also makes the title span over two lines when it
used to fit on a single one. I would like to suggest the following:

str_printf(&title, _("Enter (sub)string or regexp to search for "
"(with or without \"%s\")"), CONFIG_);

Rationale: the "(with or without CONFIG_)" makes things clear enough
IMHO, making the first occurrence redundant.

But if you don't like this proposal then let's just go with yours, it's
up to you.

>
> again:
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 0183153..7975d8d 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -695,7 +695,7 @@ static void search_conf(void)
> int dres;
>
> title = str_new();
> - str_printf( &title, _("Enter %s (sub)string to search for "
> + str_printf( &title, _("Enter %s (sub)string or regexp to search for "
> "(with or without \"%s\")"), CONFIG_, CONFIG_);
>
> again:

--
Jean Delvare
Suse L3