Re: [PATCH] Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"

Yann E. MORIN
2013-06-26T21:44:31Z

Michal, All,

On 2013-06-26 15:48 +0200, Michal Marek spake thusly:
> On Tue, Jun 25, 2013 at 11:37:44PM +0200, Yann E. MORIN wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > This reverts commit 8357b48549e17b3e4e402c7f977b65708922e60f.
> >
> > It breaks more stuff than it fixes.
>
> Thanks, I applied it to kbuild.git#kconfig, after verifying that the
> issue is gone.

Yes, thanks. I'm sorry this second attempt was a (slightly different!)
failure again. :-(

The fix is working for boolean choices, but exposes a latent bug on
tristate changes. Obviously, we must fix that latent bug first, but I
can't come to a sane solution.

I'll let it mature in a corner of my head for one more night. Maybe I'll
see things clearer tomorrow. ;-)

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'