Re: kconfig/menu.c: Fixup to "kconfig: fix undesirable side effect of adding "visible" menu attribute" ?

Dirk Gouders
2013-07-31T14:47:49Z

Sedat Dilek <sedat.dilek@gmail.com> writes:

> Hi,
>
> The Freetz router project has 370 [1] as a revert-patch of [2] to its
> kconfig-v3.8.
>
> commit 7ad1227818f09242cfe9bf1845fd24211f5f99bd
> "kconfig: fix undesirable side effect of adding "visible" menu attribute"
>
> I am not a kconfig-expert, but [3] looks like a fixup/folowup to it.
>
> commit/?id=e983b7b17ad1a978e954e6aaa62cf12bfc747883
> "kconfig/menu.c: fix multiple references to expressions in menu_add_prop()"
>
> I contacted Yann in private, but I think this is worth to ask on the
> linux-kbuild ML.

Hi Sedat,

you are right, [3] fixes a problem that was introduced by [2].
(I should have noted that in the commit message -- I'm not sure if we
can fix that afterwards.)

Best regards,

Dirk

> Thanks in advance for your help.

> Regards,
> - Sedat -
>
> [1] http://freetz.org/browser/trunk/tools/make/patches/370-save-hidden-prompts-to-file.kconfig.patch
> [2] kconfig: fix undesirable side effect of adding "visible" menu attribute
> [3] kconfig/menu.c: fix multiple references to expressions in menu_add_prop()
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html