From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: David Graeff <david.graeff@web.de>
Cc: linux-kbuild@vger.kernel.org, sam@ravnborg.org
Subject: Re: [PATCH v2 0/4] Gtk/Qt interface flavours ported to newest toolkit versions
Date: Sun, 4 Aug 2013 13:02:44 +0200 [thread overview]
Message-ID: <20130804110244.GA3481@free.fr> (raw)
In-Reply-To: <1375612711-17140-1-git-send-email-david.graeff@web.de>
David, All,
On 2013-08-04 12:38 +0200, David Graeff spake thusly:
> Hi Sam, Yann, all,
>
> I prepared a rebased V2 of the patchset. As far as I get the consensus
> is to replace the existing Qtk and Qt flavours because there exist a
^^^
Qtk, a new toolkit as a merge of Gtk and Qt? ;-)
> fallback (n/mconf) for users that do not have the never libs available.
Yes, that was my understanding as well.
> I reorganized the commits and used "-D -M" flags this time for a better
> review. There are some tool generated files like gconfig/gconf.ui and
> qconfig/mainwindow.ui which surely break the 80-column readability rule
> but are best viewed in their respective editor (gtk: glade, qt: designer)
> anyway.
>
> The Qt flavour is Qt5 compatible but I did not changed the build system
> to actually use Qt5. I've tested the Qt flavour with Qt 4.8.4, the Gtk
> flavour with Gtk 3.6.4.
As I previously said, I don't have much insight in Qt or Gtk, so I'm not
in a position to properly review those patches. I'll give them a spin at
testing, but not much more. Let's see what happens until the next merge
window. ;-)
Anyway, I like how you cleaned up scripts/kconfig by moving frontends to
their own sub-dir.
/me wonders how much kconfig-frontends [0] will be impacted by this
reordering...
> I have another question regarding the patch procedure: I've seen some
> mails here only requesting for pull requests. Is it common to send pull
> requests instead of a set of patches?
You want to send patches to the list for people to review them and
comment. You don't use pull-requests for this, since the pull-request
only contains a single mail [1] with the URL to pull from.
Once everything is OK, either the maintainer will apply those patches,
or a sub-maintainer will do it and send a pull-request for 'big' series.
So, you did well to send patches.
[0] http://ymorin.is-a-geek.org/projects/kconfig-frontends
[1] I have a script that sends a pull-request, and send individual
patches as a reply to this mail, but standard git-request-pull
does not.
Regards,
Yann E. MORIN.
> Regards,
> David
>
> David Graeff (4):
> KConf: Move flavours into their own subdirectories.
> KConf: Update/Port Gtk flavour to use Gtk3
> KConf: Qt interface port to Qt4/Qt5, removed Qt3 Support
> KConf: images.c for gtk/qt gui flavour reoganized
>
> scripts/kconfig/Makefile | 189 +--
> scripts/kconfig/gconf.c | 1542 ------------------
> scripts/kconfig/gconfig/Makefile | 69 +
> scripts/kconfig/gconfig/gconf.c | 758 +++++++++
> scripts/kconfig/{ => gconfig}/gconf.glade | 0
> scripts/kconfig/gconfig/gconf.h | 80 +
> scripts/kconfig/gconfig/gconf.ui | 536 ++++++
> scripts/kconfig/gconfig/gconf_treeview_model.c | 706 ++++++++
> scripts/kconfig/gconfig/gconf_treeview_model.h | 43 +
> scripts/kconfig/gconfig/util.h | 33 +
> scripts/kconfig/images.c | 309 ++--
> scripts/kconfig/lxdialog/Makefile | 42 +
> scripts/kconfig/{ => lxdialog}/mconf.c | 4 +-
> scripts/kconfig/nconfig/Makefile | 26 +
> scripts/kconfig/{ => nconfig}/nconf.c | 2 +-
> scripts/kconfig/{ => nconfig}/nconf.gui.c | 0
> scripts/kconfig/{ => nconfig}/nconf.h | 0
> scripts/kconfig/qconf.cc | 1790 ---------------------
> scripts/kconfig/qconf.h | 337 ----
> scripts/kconfig/qconfig/Makefile | 94 ++
> scripts/kconfig/qconfig/infoViewWidget.cc | 225 +++
> scripts/kconfig/qconfig/infoViewWidget.h | 42 +
> scripts/kconfig/qconfig/mainwindow.cc | 382 +++++
> scripts/kconfig/qconfig/mainwindow.h | 73 +
> scripts/kconfig/qconfig/mainwindow.ui | 410 +++++
> scripts/kconfig/qconfig/qconf.cc | 77 +
> scripts/kconfig/qconfig/qconf.h | 23 +
> scripts/kconfig/qconfig/searchfiltermodelproxy.cc | 35 +
> scripts/kconfig/qconfig/searchfiltermodelproxy.h | 35 +
> scripts/kconfig/qconfig/searchmodel.cc | 57 +
> scripts/kconfig/qconfig/searchmodel.h | 28 +
> 31 files changed, 3953 insertions(+), 3994 deletions(-)
> delete mode 100644 scripts/kconfig/gconf.c
> create mode 100644 scripts/kconfig/gconfig/Makefile
> create mode 100644 scripts/kconfig/gconfig/gconf.c
> rename scripts/kconfig/{ => gconfig}/gconf.glade (100%)
> create mode 100644 scripts/kconfig/gconfig/gconf.h
> create mode 100644 scripts/kconfig/gconfig/gconf.ui
> create mode 100644 scripts/kconfig/gconfig/gconf_treeview_model.c
> create mode 100644 scripts/kconfig/gconfig/gconf_treeview_model.h
> create mode 100644 scripts/kconfig/gconfig/util.h
> create mode 100644 scripts/kconfig/lxdialog/Makefile
> rename scripts/kconfig/{ => lxdialog}/mconf.c (99%)
> create mode 100644 scripts/kconfig/nconfig/Makefile
> rename scripts/kconfig/{ => nconfig}/nconf.c (99%)
> rename scripts/kconfig/{ => nconfig}/nconf.gui.c (100%)
> rename scripts/kconfig/{ => nconfig}/nconf.h (100%)
> delete mode 100644 scripts/kconfig/qconf.cc
> delete mode 100644 scripts/kconfig/qconf.h
> create mode 100644 scripts/kconfig/qconfig/Makefile
> create mode 100644 scripts/kconfig/qconfig/infoViewWidget.cc
> create mode 100644 scripts/kconfig/qconfig/infoViewWidget.h
> create mode 100644 scripts/kconfig/qconfig/mainwindow.cc
> create mode 100644 scripts/kconfig/qconfig/mainwindow.h
> create mode 100644 scripts/kconfig/qconfig/mainwindow.ui
> create mode 100644 scripts/kconfig/qconfig/qconf.cc
> create mode 100644 scripts/kconfig/qconfig/qconf.h
> create mode 100644 scripts/kconfig/qconfig/searchfiltermodelproxy.cc
> create mode 100644 scripts/kconfig/qconfig/searchfiltermodelproxy.h
> create mode 100644 scripts/kconfig/qconfig/searchmodel.cc
> create mode 100644 scripts/kconfig/qconfig/searchmodel.h
>
> --
> 1.8.1.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-08-04 11:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <kconfig-port-gtk-qt>
2013-07-02 15:22 ` Kconfig Gtk/Qt interface flavours ported to newest toolkit versions davidgraeff
2013-07-02 15:22 ` [PATCH 2/9] kconfig: Update gtk interface codebase davidgraeff
2013-07-02 15:22 ` [PATCH 3/9] kconfig: gtk interface port to Gtk3 davidgraeff
2013-07-02 15:22 ` [PATCH 4/9] kconfig: gtk interface: fix splitview, split code into two files davidgraeff
2013-07-02 15:22 ` [PATCH 5/9] kconfig: images.c for gtk/qt gui flavour reoganized davidgraeff
2013-07-02 15:22 ` [PATCH 6/9] kconf: gtk: move relayout code out of a loop davidgraeff
2013-07-13 8:56 ` Sam Ravnborg
2013-07-02 15:22 ` [PATCH 8/9] kconfig: qt flavour makefile fixes davidgraeff
2013-07-02 15:22 ` [PATCH 9/9] kconfig: qt flavour, add missing updateTree davidgraeff
2013-07-03 16:30 ` Kconfig Gtk/Qt interface flavours ported to newest toolkit versions Yann E. MORIN
2013-07-06 0:13 ` David Gräff
2013-07-10 21:32 ` Yann E. MORIN
2013-07-11 21:02 ` Sam Ravnborg
2013-07-11 20:56 ` Sam Ravnborg
2013-07-11 21:06 ` Sam Ravnborg
2013-08-04 10:38 ` [PATCH v2 0/4] " David Graeff
2013-08-04 10:38 ` [PATCH v2 1/4] KConf: Move flavours into their own subdirectories David Graeff
2013-08-10 9:06 ` Sam Ravnborg
2013-08-16 14:13 ` Michal Marek
2013-08-04 10:38 ` [PATCH v2 4/4] KConf: images.c for gtk/qt gui flavour reoganized David Graeff
2013-08-10 9:10 ` Sam Ravnborg
2013-08-04 11:02 ` Yann E. MORIN [this message]
2013-08-04 15:40 ` [PATCH v2 0/4] Gtk/Qt interface flavours ported to newest toolkit versions David Gräff
2013-08-10 9:01 ` Sam Ravnborg
2013-08-16 13:28 ` Michal Marek
2013-08-16 13:36 ` Yann E. MORIN
2013-08-16 14:02 ` Michal Marek
2013-08-19 14:29 ` [PATCH v3 0/5] Kconfig " David Graeff
2013-11-18 18:18 ` Yann E. MORIN
2013-08-19 14:29 ` [PATCH v3 1/5] kconfig: Move flavours into their own subdirectories David Graeff
2013-08-19 14:29 ` [PATCH v3 2/5] kconfig: Add qconfig makefile target additionally to the xconfig target David Graeff
2013-08-19 14:29 ` [PATCH v3 5/5] kconfig: images.c for gtk/qt gui flavour reoganized David Graeff
2013-08-19 17:50 ` [PATCH v3 6/6] kconfig: Update POTFILES.in to reflect new directory structure David Graeff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130804110244.GA3481@free.fr \
--to=yann.morin.1998@free.fr \
--cc=david.graeff@web.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox