* [PATCH] buildtar: Add ARCH to the archive name
@ 2013-03-06 8:05 Borislav Petkov
2013-03-07 11:06 ` Joerg Roedel
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2013-03-06 8:05 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild, LKML, Borislav Petkov
From: Borislav Petkov <bp@suse.de>
When dealing with multiple sub-arches (like 32- and 64-bit on x86, for
example) generating a bunch of kernel tar archives with the same name
but for different sub-arches could get confusing and error-prone. Also,
the build process could overwrite otherwise unrelated builds and you
probably don't want that. So, add the architecture to the archive name
for more clarity and less shoot-yourself-in-the-foot practices.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
scripts/package/buildtar | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/buildtar b/scripts/package/buildtar
index 62d8234f8787..cdd9bb909bcd 100644
--- a/scripts/package/buildtar
+++ b/scripts/package/buildtar
@@ -16,7 +16,7 @@ set -e
# Some variables and settings used throughout the script
#
tmpdir="${objtree}/tar-install"
-tarball="${objtree}/linux-${KERNELRELEASE}.tar"
+tarball="${objtree}/linux-${KERNELRELEASE}-${ARCH}.tar"
#
--
1.8.1.3.535.ga923c31
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] buildtar: Add ARCH to the archive name
2013-03-06 8:05 [PATCH] buildtar: Add ARCH to the archive name Borislav Petkov
@ 2013-03-07 11:06 ` Joerg Roedel
2013-03-07 11:09 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Joerg Roedel @ 2013-03-07 11:06 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Michal Marek, linux-kbuild, LKML, Borislav Petkov
On Wed, Mar 06, 2013 at 09:05:47AM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> When dealing with multiple sub-arches (like 32- and 64-bit on x86, for
> example) generating a bunch of kernel tar archives with the same name
> but for different sub-arches could get confusing and error-prone. Also,
> the build process could overwrite otherwise unrelated builds and you
> probably don't want that. So, add the architecture to the archive name
> for more clarity and less shoot-yourself-in-the-foot practices.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Good idea, but I already hear people yelling about their scripts that
break with this change :)
Joerg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] buildtar: Add ARCH to the archive name
2013-03-07 11:06 ` Joerg Roedel
@ 2013-03-07 11:09 ` Borislav Petkov
2013-04-08 14:05 ` Michal Marek
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2013-03-07 11:09 UTC (permalink / raw)
To: Joerg Roedel; +Cc: Michal Marek, linux-kbuild, LKML, Borislav Petkov
On Thu, Mar 07, 2013 at 12:06:59PM +0100, Joerg Roedel wrote:
> Good idea, but I already hear people yelling about their scripts that
> break with this change :)
They better fix them then. :-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] buildtar: Add ARCH to the archive name
2013-03-07 11:09 ` Borislav Petkov
@ 2013-04-08 14:05 ` Michal Marek
2013-04-08 14:26 ` Borislav Petkov
0 siblings, 1 reply; 6+ messages in thread
From: Michal Marek @ 2013-04-08 14:05 UTC (permalink / raw)
To: Borislav Petkov, Joerg Roedel, linux-kbuild, LKML,
Borislav Petkov
On 7.3.2013 12:09, Borislav Petkov wrote:
> On Thu, Mar 07, 2013 at 12:06:59PM +0100, Joerg Roedel wrote:
>> Good idea, but I already hear people yelling about their scripts that
>> break with this change :)
>
> They better fix them then. :-)
OK, I applied the patch to kbuild.git#misc. Let's see how many people
protest...
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] buildtar: Add ARCH to the archive name
2013-04-08 14:05 ` Michal Marek
@ 2013-04-08 14:26 ` Borislav Petkov
[not found] ` <CAKA=qzZRfSD33u4cXvpnzQn5isNB4iNY4cibeAwY46gyFmMHhg@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Borislav Petkov @ 2013-04-08 14:26 UTC (permalink / raw)
To: Michal Marek; +Cc: Joerg Roedel, linux-kbuild, LKML, Borislav Petkov
On Mon, Apr 08, 2013 at 04:05:53PM +0200, Michal Marek wrote:
> On 7.3.2013 12:09, Borislav Petkov wrote:
> > On Thu, Mar 07, 2013 at 12:06:59PM +0100, Joerg Roedel wrote:
> >> Good idea, but I already hear people yelling about their scripts that
> >> break with this change :)
> >
> > They better fix them then. :-)
>
> OK, I applied the patch to kbuild.git#misc. Let's see how many people
> protest...
Yeah, leave it in there for 3.10 so that it sees a whole cycle of
testing in -next and what not, so that we can see who complains. :)
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] buildtar: Add ARCH to the archive name
[not found] ` <CAKA=qzZRfSD33u4cXvpnzQn5isNB4iNY4cibeAwY46gyFmMHhg@mail.gmail.com>
@ 2013-09-12 12:46 ` Borislav Petkov
0 siblings, 0 replies; 6+ messages in thread
From: Borislav Petkov @ 2013-09-12 12:46 UTC (permalink / raw)
To: Josh Hunt; +Cc: Michal Marek, Joerg Roedel, linux-kbuild, LKML, Borislav Petkov
On Wed, Sep 11, 2013 at 06:35:08PM -0500, Josh Hunt wrote:
> I didn't take the time to build the rpm pkg, but deb-pkg produces files
> like:
>
> linux-image-3.10.0-rc7_3.10.0-rc7-26_amd64.deb
>
> tarbz2-pkg now produces files with the name of:
> linux-3.10.0-rc7-x86.tar.bz2
Right, I'm not really happy with this solution too because builds which
don't supply ARCH on the command line add "x86" to the archive name
and my intention was to have either "i386" or "x86_64" appended to the
archive name so that when building a bunch of different kernel packages,
I can know which is 32-bit and which is 64-bit.
Having it say "x86" doesn't tell me all that much. Whether it has "-" or
an "_" prepended I don't care.
So I'll go and revisit this thing. I'll add you to CC for feedback since
your script got broke :)
And, btw, other suggestions are appreciated too.
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-12 12:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-06 8:05 [PATCH] buildtar: Add ARCH to the archive name Borislav Petkov
2013-03-07 11:06 ` Joerg Roedel
2013-03-07 11:09 ` Borislav Petkov
2013-04-08 14:05 ` Michal Marek
2013-04-08 14:26 ` Borislav Petkov
[not found] ` <CAKA=qzZRfSD33u4cXvpnzQn5isNB4iNY4cibeAwY46gyFmMHhg@mail.gmail.com>
2013-09-12 12:46 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox