public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kconfig: fix allmodconfig
@ 2013-09-21 23:17 Yann E. MORIN
  2013-09-21 23:21 ` Yann E. MORIN
  0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2013-09-21 23:17 UTC (permalink / raw)
  To: linux-kbuild; +Cc: Yann E. MORIN, Stephen Rothwell, Sam Ravnborg, Michal Marek

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>
---
 scripts/kconfig/confdata.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 87f7238..0cbfc67 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -399,8 +399,6 @@ setsym:
 	free(line);
 	fclose(in);
 
-	if (modules_sym)
-		sym_calc_value(modules_sym);
 	return 0;
 }
 
@@ -1175,6 +1173,10 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)
 				sym->def[S_DEF_USER].tri = yes;
 				break;
 			case def_mod:
+				/* Note: although modules_sym must be 'yes' to
+				 * enable tristates, 'mod' is promoted to 'yes'
+				 * when applied to a boolean, which modules_sym
+				 * is. So we need not special-case it here. */
 				sym->def[S_DEF_USER].tri = mod;
 				break;
 			case def_no:
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-10-08 21:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-21 23:17 [PATCH] kconfig: fix allmodconfig Yann E. MORIN
2013-09-21 23:21 ` Yann E. MORIN
2013-09-26 21:36   ` Yann E. MORIN
2013-09-27 10:19     ` Michal Marek
2013-09-27 20:02       ` Yann E. MORIN
2013-10-02 20:29       ` Michal Marek
2013-10-03 22:02         ` Yann E. MORIN
2013-10-08 21:54           ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox