Re: [PATCH] kconfig: fix allmodconfig

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Michal, Al,

On 2013-10-04 00:02 +0200, Yann E. MORIN spake thusly:
> On 2013-10-02 22:29 +0200, Michal Marek spake thusly:
> > Dne 27.9.2013 12:19, Michal Marek napsal(a):
> > > On 26.9.2013 23:36, Yann E. MORIN wrote:
> > >> Hello All!
> > >>
> > >> On 2013-09-22 01:21 +0200, Yann E. MORIN spake thusly:
> > >>> Stephen, All,
> > >>>
> > >>> Please, test this patch to fix the allmodconfig issue reported by
> > >>> Stephen.
> > >>>
> > >>> From my little testing (some randconfig followed by silentoldconfig, as
> > >>> well as allmodconfig), this patch seems to fix the issue without any
> > >>> regression I could ientify.
> > >>>
> > >>> But since this is sensitive code, I'd like some feedback before this
> > >>> gets applied.
> > >>
> > >> Ping? :-)
> > >>
> > >> I wanted to push this right after -rc3 is out. If any one has an issue
> > >> with that patch, you've got a few days to chime in! ;-)
> > > 
> > > It works for me, you can add my Tested-by: if you like. The only issue I
> > > have is that a more verbose changelog is missing.
> > 
> > Sorry, I have to retract my Tested-by. When I merge your rc-fixes branch
> > into 3.12-rc1, I get this behavior:
> > 
> > $ make mrproper
> > $ make allmodconfig
> > ...
> > scripts/kconfig/conf --allmodconfig Kconfig
> > #
> > # configuration written to .config
> > #$ make silentoldconfig
> > scripts/kconfig/conf --silentoldconfig Kconfig
> > *
> > * Restart config...
> > *
> > (this should not happen)
> > *
> > * PHY Device support and infrastructure
> > *
> > PHY Device support and infrastructure (PHYLIB) [Y/?] y
> >   *
> >   * MII PHY device drivers
> >   *
> >   Drivers for Atheros AT803X PHYs (AT803X_PHY) [M/n/y/?] m
> >   Drivers for the AMD PHYs (AMD_PHY) [M/n/y/?] m
> >   Drivers for Marvell PHYs (MARVELL_PHY) [M/n/y/?] m
> >   Drivers for Davicom PHYs (DAVICOM_PHY) [M/n/y/?] m
> >   Drivers for Quality Semiconductor PHYs (QSEMI_PHY) [M/n/y/?] m
> >   Drivers for the Intel LXT PHYs (LXT_PHY) [M/n/y/?] m
> >   Drivers for the Cicada PHYs (CICADA_PHY) [M/n/y/?] m
> >   Drivers for the Vitesse PHYs (VITESSE_PHY) [M/n/y/?] m
> >   Drivers for SMSC PHYs (SMSC_PHY) [M/y/?] m
> >   Drivers for Broadcom PHYs (BROADCOM_PHY) [M/n/y/?] m
> >   Driver for Broadcom BCM8706 and BCM8727 PHYs (BCM87XX_PHY) [M/n/y/?] m
> >   Drivers for ICPlus PHYs (ICPLUS_PHY) [M/n/y/?] m
> >   Drivers for Realtek PHYs (REALTEK_PHY) [M/n/y/?] m
> >   Drivers for National Semiconductor PHYs (NATIONAL_PHY) [M/n/y/?] m
> >   Driver for STMicroelectronics STe10Xp PHYs (STE10XP) [M/n/y/?] m
> >   Driver for LSI ET1011C PHY (LSI_ET1011C_PHY) [M/n/y/?] m
> >   Driver for Micrel PHYs (MICREL_PHY) [M/n/y/?] m
> >   Driver for MDIO Bus/PHY emulation with fixed speed/link PHYs
> > (FIXED_PHY) [N/y/?] (NEW)
> > 
> > The .config generated by make allmodconfig is identical to a .config
> > generated with plain v3.12-rc1 and thus correct. It's (silent)oldconfig
> > that has a problem.
> 
> Doh... :-(
> 
> I've played with this a bit, and I noticed that if you do:
>     $ git clean -dX; git clean -d    # Make sure tree is clean
>     $ make allmodconfig
>     $ grep PHYLIB= .config
>     CONFIG_PHYLIB=m
>     $ make menuconfig
>         Device Drivers  -->
>           Network device support  -->
>             -*-  PHY Device support and infrastructure  -->
> 
> Notice how "PHY Device support and infrastructure" is forced to 'y', not
> 'm'. This is expected, because it is selected by (there are other terms
> in the equation that also force it to 'y'):
>     ETHOC [=y] && NETDEVICES [=y] && ETHERNET [=y]
>     && HAS_IOMEM [=y] && HAS_DMA [=y]
> 
> Hence, what we see is that "make allmodconfig" does not properly resolve
> the symbols values.
> 
> I'll tackle this, but it may take some time...

OK, I have no clue... :-(
Any suggestion?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'