Re: [PATCH] kconfig: add comment about 'jump maybe used unitialized'

[Benjamin Poirier <bpoirier@suse.de>]

On 2013/11/19 11:13, Michal Marek wrote:
> On 19.11.2013 08:27, Madhavan Srinivasan wrote:
> > On Tuesday 19 November 2013 02:33 AM, Yann E. MORIN wrote:
> >>
> >> Madhavan, Christian, if you could give a bit ;ore details on the distro
> >> you're using, that be nice so we can have a more descriptive commit log.
> > 
> > When I initially reported this issue, it was in gcc version 4.8.0
> > 20130526. And I am trying this now in a beta release of RHEL7 with gcc
> > version 4.8.1 20131002 (Red Hat 4.8.1-11) (GCC) and I still see the
> > reported issue.
> 
> In that case, I'd just give up and initialize jump to NULL. Worst case,
> we will get a segfault at runtime if a genuine bug is introduced into
> the function. What do you think?

I've tried it again on openSUSE 13.1 which has
gcc (SUSE Linux) 4.8.1 20130909 [gcc-4_8-branch revision 202388]
and I don't see the warning. I may be missing something because I've
also tried on Debian Wheezy (as reported by Christian Kujau) but I don't
see a warning either. It was on x86 however, not ppc.

In any case, given that it's been reported a few times I agree with
Michal and I'd do something like this:

-	struct jump_key *jump;
+	/* Initialize jump to work around a spurious warning emitted by
+	 * certain versions of gcc */
+	struct jump_key *jump = NULL;