From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
David Rientjes <rientjes@google.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
James Hogan <james.hogan@imgtec.com>,
Michal Marek <mmarek@suse.cz>, Paul Mundt <lethal@linux-sh.org>,
Shawn Guo <shawn.guo@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [patch core/stackprotector] stackprotector: Fix build when compiler lacks support
Date: Wed, 1 Jan 2014 12:42:44 +0100 [thread overview]
Message-ID: <20140101114244.GB3372@free.fr> (raw)
In-Reply-To: <CA+55aFy65HwuqjsZhhTDBy1GYyxig8De=3XZxn8ixnGN7xWMFQ@mail.gmail.com>
Linus, All,
On 2013-12-31 16:16 -0800, Linus Torvalds spake thusly:
> On Mon, Dec 30, 2013 at 4:45 PM, Kees Cook <keescook@chromium.org> wrote:
> >
> > NAK. If you have selected CONFIG_CC_STACKPROTECTOR_STRONG, the build
> > the fail hard. Without this, it means you'll end up with kernels that
> > build and show a stackprotector option in their config, which is
> > false.
>
> What we really really want to do is to have some way to add config
> options based on shell scripts and compiler support. That would also
> get rid of a lot of Makefile trickery etc.
>
> Then we could just make CC_STACKPROTECTOR_STRONG depend on
> CC_SUPPORTS_STACKPROTECTOR_STRONG or whatever.
Sam Ravnborg suggested somethink along those lines back in July:
http://marc.info/?l=linux-kbuild&m=137399785206527&w=2
and a tentative implementation:
http://marc.info/?l=linux-kbuild&m=137409581406434&w=2
Basically, that would give something like:
config CC_SUPPORTS_STACKPROTECTOR_STRONG
bool
option exec="some/script/to/test-gcc -fstack-protector-strong"
config CC_STACKPROTECTOR_STRONG
bool "enable stack-protector strong"
depends on CC_SUPPORTS_STACKPROTECTOR_STRONG
Would that be something that match what you suggested above?
Sam, there were some comments on that patch of yours. Do you want to
update it and resubmit it?
And, Happy New Year to All!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-01-01 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 19:35 [PATCH v5] provide -fstack-protector-strong build option Kees Cook
2013-12-19 19:35 ` [PATCH v5 1/2] create HAVE_CC_STACKPROTECTOR for centralized use Kees Cook
2013-12-19 19:35 ` [PATCH v5 2/2] provide -fstack-protector-strong build option Kees Cook
[not found] ` <tip-8779657d29c0ebcc0c94ede4df2f497baf1b563f@git.kernel.org>
2013-12-30 21:37 ` [patch core/stackprotector] stackprotector: Fix build when compiler lacks support David Rientjes
2013-12-31 0:45 ` Kees Cook
2014-01-01 0:16 ` Linus Torvalds
2014-01-01 11:42 ` Yann E. MORIN [this message]
2014-01-01 19:33 ` Linus Torvalds
2014-01-01 19:50 ` H. Peter Anvin
2014-01-01 22:28 ` Yann E. MORIN
2014-01-05 22:13 ` Sam Ravnborg
2013-12-31 14:39 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140101114244.GB3372@free.fr \
--to=yann.morin.1998@free.fr \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=lethal@linux-sh.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@kernel.org \
--cc=mmarek@suse.cz \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rientjes@google.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
--cc=shawn.guo@linaro.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox