From: Andrew Morton <akpm@linux-foundation.org>
To: "Daniel M. Weeks" <dan@danweeks.net>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyungsik Lee <kyungsik.lee@lge.com>
Subject: Re: [PATCH] Fix flags for initramfs LZ4 compression
Date: Tue, 18 Feb 2014 16:06:58 -0800 [thread overview]
Message-ID: <20140218160658.fa2802ce37e5169c5b7cf296@linux-foundation.org> (raw)
In-Reply-To: <20140215231447.GA30803@dev.danweeks.net>
On Sat, 15 Feb 2014 18:14:57 -0500 "Daniel M. Weeks" <dan@danweeks.net> wrote:
> LZ4 as implemented in the kernel differs from the default method now
> used by the reference implementation of LZ4. Until the in-kernel method
> is updated to support the new default, passing the legacy flag (-l) to
> the compressor is necessary. Without this flag the kernel-generated,
> LZ4-compressed initramfs is junk.
Well that's bad. Kyungsik, cuold you please comment?
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -257,7 +257,7 @@ case "$arg" in
> && compr="lzop -9 -f"
> echo "$output_file" | grep -q "\.lz4$" \
> && [ -x "`which lz4 2> /dev/null`" ] \
> - && compr="lz4 -9 -f"
> + && compr="lz4 -l -9 -f"
> echo "$output_file" | grep -q "\.cpio$" && compr="cat"
> shift
> ;;
next prev parent reply other threads:[~2014-02-19 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 23:14 [PATCH] Fix flags for initramfs LZ4 compression Daniel M. Weeks
2014-02-19 0:06 ` Andrew Morton [this message]
2014-02-19 0:08 ` Andrew Morton
2014-02-19 7:51 ` Kyungsik Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218160658.fa2802ce37e5169c5b7cf296@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan@danweeks.net \
--cc=kyungsik.lee@lge.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox