From: Michal Marek <mmarek@suse.cz>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-kbuild@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 2/2] kbuild: docbook: specify KERNELDOC dependency correctly
Date: Fri, 14 Mar 2014 18:11:22 +0100 [thread overview]
Message-ID: <20140314171122.GC18789@sepie.suse.cz> (raw)
In-Reply-To: <1390194611-15102-2-git-send-email-yamada.m@jp.panasonic.com>
On Mon, Jan 20, 2014 at 02:10:11PM +0900, Masahiro Yamada wrote:
> It is not a good idea to describe
>
> %.xml: %.tmpl FORCE
> ...
>
> and
>
> $(BOOKS): $(KERNELDOC)
>
> separately. This cannot detect missing template files.
>
> For example, add something to DOCBOOKS variable:
> DOCBOOKS += foobar.xml
> and run
> make xmldocs
>
> It will succeed even if Documention/DocBook/foobar.tmpl
> does not exist.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Applied to kbuild.git#kbuild, thanks.
Michal
> ---
> Documentation/DocBook/Makefile | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 237f6dc..824d26a 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -87,13 +87,9 @@ define rule_docproc
> ) > $(dir $@).$(notdir $@).cmd
> endef
>
> -%.xml: %.tmpl FORCE
> +%.xml: %.tmpl $(KERNELDOC) $(DOCPROC) FORCE
> $(call if_changed_rule,docproc)
>
> -###
> -# Changes in kernel-doc force a rebuild of all documentation
> -$(BOOKS): $(KERNELDOC)
> -
> # Tell kbuild to always build the programs
> always := $(hostprogs-y)
>
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-14 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 5:10 [PATCH 1/2] kbuild: docbook: include cmd files more simply Masahiro Yamada
2014-01-20 5:10 ` [PATCH 2/2] kbuild: docbook: specify KERNELDOC dependency correctly Masahiro Yamada
2014-03-14 17:11 ` Michal Marek [this message]
2014-03-14 17:10 ` [PATCH 1/2] kbuild: docbook: include cmd files more simply Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314171122.GC18789@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox