public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] arm, kbuild: Do not define "comma" twice
Date: Fri, 28 Mar 2014 16:05:58 +0900	[thread overview]
Message-ID: <20140328160558.DB4D.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1386902233-6280-1-git-send-email-yamada.m@jp.panasonic.com>

Hi Michal,

Does this patch look good?
Any problem? Or should I have sent it to arm-kernel, not linux-kbuild ML?

Thanks.

Masahiro Yamada



On Fri, 13 Dec 2013 11:37:13 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:

> We have the definition of "comma" in scripts/Kbuild.include.
> We should not double it.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>  arch/arm/Makefile   | 2 --
>  arch/arm64/Makefile | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index db50b62..60351d2 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -53,8 +53,6 @@ AS		+= -EL
>  LD		+= -EL
>  endif
>  
> -comma = ,
> -
>  # This selects which instruction set is used.
>  # Note that GCC does not numerically define an architecture version
>  # macro, but instead defines a whole series of macros which makes
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index d90cf79..75c5527 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -24,8 +24,6 @@ KBUILD_CPPFLAGS	+= -mlittle-endian
>  AS		+= -EL
>  LD		+= -EL
>  
> -comma = ,
> -
>  CHECKFLAGS	+= -D__aarch64__
>  
>  # Default value
> -- 
> 1.8.3.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



  reply	other threads:[~2014-03-28  7:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13  2:37 [PATCH] arm, kbuild: Do not define "comma" twice Masahiro Yamada
2014-03-28  7:05 ` Masahiro Yamada [this message]
2014-03-28 10:15   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328160558.DB4D.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox