From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Kbuild: move extra gcc check flags to the top Makefile
Date: Tue, 8 Apr 2014 17:18:25 +0200 [thread overview]
Message-ID: <20140408151824.GA31595@ravnborg.org> (raw)
In-Reply-To: <53441091.2060706@suse.cz>
On Tue, Apr 08, 2014 at 05:06:57PM +0200, Michal Marek wrote:
> On 2014-04-07 05:22, Masahiro Yamada wrote:
> > If W=... given to the command line, extra gcc check flags are added
> > to KBUILD_CFLAGS.
> >
> > If we have such code in scripts/Makefile.build, the same flags are
> > added to KBUILD_CFLAGS multiple times becuase scripts/Makefile.build
> > is invoked every time Kbuild descends into the subdirectories.
>
> Indeed. For three years, nobody has noticed that the gcc commandline is
> growing with every subdirectory.
I once had a patchset that moved all this out - to avoid this.
It was lost for various reasons.
The top-level Makefile is already too cluttered - so adding all this
is not good.
Moving it all to a dedicated file would be better.
Sam
next prev parent reply other threads:[~2014-04-08 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 3:22 [PATCH] Kbuild: move extra gcc check flags to the top Makefile Masahiro Yamada
2014-04-08 15:06 ` Michal Marek
2014-04-08 15:18 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-18 5:53 [PATCH] Kbuild: Move " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408151824.GA31595@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox