Re: [PATCH] scripts/Makefile.clean: clean also $(extra-m) and $(extra-)

Michal Marek
2014-07-03T20:55:45Z

Dne 20.6.2014 15:23, Michal Marek napsal(a):
> Dne 20.6.2014 14:22, Masahiro Yamada napsal(a):
>> Hi Michal,
>>
>>
>> On Wed, 18 Jun 2014 21:53:02 +0200
>> Michal Marek <mmarek@suse.cz> wrote:
>>
>>> Dne 12.6.2014 10:24, Michal Marek napsal(a):
>>>> Dne 6.6.2014 03:43, Masahiro Yamada napsal(a):
>>>>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>>>>> ---
>>>>> scripts/Makefile.clean | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean
>>>>> index 686cb0d..a651cee 100644
>>>>> --- a/scripts/Makefile.clean
>>>>> +++ b/scripts/Makefile.clean
>>>>> @@ -40,8 +40,8 @@ subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
>>>>> # build a list of files to remove, usually relative to the current
>>>>> # directory
>>>>>
>>>>> -__clean-files := $(extra-y) $(always) \
>>>>> - $(targets) $(clean-files) \
>>>>> +__clean-files := $(extra-y) $(extra-m) $(extra-) \
>>>>> + $(always) $(targets) $(clean-files) \
>>>>
>>>> Do you have an example where generated files are left in the tree after
>>>> make clean? This should go into the changelog.
>>>
>>> Hi Masahiro,
>>>
>>> do you have a reproducer, i.e. an example where make clean leaves
>>> generated files in the tree?
>>
>> No, I don't.
>>
>> I thought
>> arch/powerpc/kernel/Makefile is using
>> extra-$(CONFIG_...) += ...
>> but *.o files are simply cleaned-up. So this isn't the case.
>
> OK, so there is no urgent need to add this to 'rc-fixes'. I'll queue it
> up in 'kbuild' for 3.17-rc1.

It's in kbuild.git#kbuild now.

Michal