From: Jason Cooper <jason@lakedaemon.net>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 6/7] scripts: objdiff: fix a comment
Date: Fri, 6 Jun 2014 11:35:48 -0400 [thread overview]
Message-ID: <20140606153548.GL8664@titan.lakedaemon.net> (raw)
In-Reply-To: <1401448315-800-7-git-send-email-yamada.m@jp.panasonic.com>
On Fri, May 30, 2014 at 08:11:54PM +0900, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Jason Cooper <jason@lakedaemon.net>
> ---
> scripts/objdiff | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/objdiff b/scripts/objdiff
> index c997e44..4d3a197 100755
> --- a/scripts/objdiff
> +++ b/scripts/objdiff
> @@ -70,7 +70,7 @@ dorecord() {
>
> [ ! -d "$dir" ] && mkdir -p $dir
>
> - # remove addresses for a more clear diff
> + # remove addresses for a clearer diff
perhaps 'for a cleaner diff' ? I have no strong opinion either way.
thx,
Jason.
> # http://dummdida.tumblr.com/post/60924060451/binary-diff-between-libc-from-scientificlinux-and
> $OBJDUMP -D $f | sed "s/^[[:space:]]\+[0-9a-f]\+//" > $dis
> done
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-06-06 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 11:11 [PATCH 0/7] scripts: objdiff: various clean-up, fix and new features Masahiro Yamada
2014-05-30 11:11 ` [PATCH 1/7] scripts: objdiff: get the path to .tmp_objdiff more simply Masahiro Yamada
2014-05-30 11:11 ` [PATCH 2/7] scripts: objdiff: direct error messages to stderr Masahiro Yamada
2014-06-06 15:28 ` Jason Cooper
2014-05-30 11:11 ` [PATCH 3/7] scripts: objdiff: remove unnecessary code Masahiro Yamada
2014-05-30 11:11 ` [PATCH 4/7] scripts: objdiff: improve path flexibility for record command Masahiro Yamada
2014-06-06 15:33 ` Jason Cooper
2014-05-30 11:11 ` [PATCH 5/7] scripts: objdiff: change the extension of disassembly from .o to .dis Masahiro Yamada
2014-05-30 11:11 ` [PATCH 6/7] scripts: objdiff: fix a comment Masahiro Yamada
2014-06-06 15:35 ` Jason Cooper [this message]
2014-05-30 11:11 ` [PATCH 7/7] scripts: objdiff: support directories for the augument of record command Masahiro Yamada
2014-06-06 15:38 ` [PATCH 0/7] scripts: objdiff: various clean-up, fix and new features Jason Cooper
2014-06-09 2:21 ` Masahiro Yamada
2014-06-10 10:04 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606153548.GL8664@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox