public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 0/5] kbuild: Clean-up and bug fixes of scripts/Makefile.host
Date: Mon, 09 Jun 2014 13:29:59 +0900	[thread overview]
Message-ID: <20140609132959.95B3.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20140606132553.GA4961@ravnborg.org>

Hi Sam,


On Fri, 6 Jun 2014 15:25:54 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:

> On Fri, Jun 06, 2014 at 10:30:58AM +0900, Masahiro Yamada wrote:
> > 
> > Masahiro Yamada (5):
> >   kbuild: fix a typo in scripts/Makefile.host
> >   kbuild: fix a bug of C++ host program handling
> >   kbuild: clean up scripts/Makefile.host
> >   kbuild: clean-up and bug fix of scripts/Makefile.host
> >   kbuild: create directory of .o files from shlib-objs notation
> 
> All bug-fixes looks good.
> But rahter than fixing this please consider if
> we can drop the features.

OK.
I dropped shared object feature and posted v2.

> The shlib stuff is for example no longer used and should be deleted.
> Do we have any host progrs where we need to create directories as
> is fixed in these patches?
> If not then rip it out too.

I hesitate to remove directory creation feature because:

[1] Kbuild is already used in some other projects. 
     Makefile.build, Makefile.lib, Makefile.host etc.
    are really useful build scripts.
    So, I think they should be kept generic enough
    for the maximum code re-use  in other projects.
    It is true that we no longer have hostprogs in Kernel where
    we need to create directories.
    But there might  be necessity in other projects.
    (At least, U-boot's hostprogs-y is depending on this feature.)
[2] For consistency.
     obj-y supports automatic directory creation.
     It is symmetrical that we support it for hostprogs-y.

In v2,  I simplified Makefile.host much more,
so please let me keep it.


Best Regards
Masahiro Yamada


      reply	other threads:[~2014-06-09  4:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  1:30 [PATCH 0/5] kbuild: Clean-up and bug fixes of scripts/Makefile.host Masahiro Yamada
2014-06-06  1:30 ` [PATCH 1/5] kbuild: fix a typo in scripts/Makefile.host Masahiro Yamada
2014-06-06  1:31 ` [PATCH 2/5] kbuild: fix a bug of C++ host program handling Masahiro Yamada
2014-06-06  1:31 ` [PATCH 3/5] kbuild: clean up scripts/Makefile.host Masahiro Yamada
2014-06-06  1:31 ` [PATCH 4/5] kbuild: clean-up and bug fix of scripts/Makefile.host Masahiro Yamada
2014-06-06  1:31 ` [PATCH 5/5] kbuild: create directory of .o files from shlib-objs notation Masahiro Yamada
2014-06-06 13:25 ` [PATCH 0/5] kbuild: Clean-up and bug fixes of scripts/Makefile.host Sam Ravnborg
2014-06-09  4:29   ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140609132959.95B3.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox