Re: [PATCH] kbuild: rename CONFIG_SHELL to KBUILD_SHELL

[Sam Ravnborg <sam@ravnborg.org>]

On Mon, Jun 09, 2014 at 09:31:22PM +0900, Masahiro Yamada wrote:
> All the macros with CONFIG_ prefix are supposed to be defined
> in Kconfig. But CONFIG_SHELL is defined in the top Makefile,
> violating the namespace rule.
> 
> Is is impossible to move CONFIG_SHELL definition to Kconfig.
> Configuration rules depend on "outputmakefile" rule where
> CONFIG_SHELL is already used.
> (Kbuild has to know which shell to use before invoking "make config".)
> 
> So, it seems better to rename CONFIG_SHELL.
> Because "SHELL" is a special variable for GNU make, we should not
> use it. It looks like "KBUILD_SHELL" is a good choice.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Michal Marek <mmarek@suse.cz>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Please do a follow-up path that adds this variable to the list
in Documentation/kbuild/kbuild.txt

And please cc: the x86 people - thay have some patches that
uses CONFIG_SHELL IIRC.

The original (CONFIG_SHELL) was missing which is why you did not catch this.

	Sam