From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: trivial - use tabs for code indent where possible
Date: Tue, 10 Jun 2014 10:53:08 +0900 [thread overview]
Message-ID: <20140610105308.95F4.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <53962E47.9030204@suse.cz>
Hi Michal,
On Mon, 09 Jun 2014 23:59:35 +0200
Michal Marek <mmarek@suse.cz> wrote:
> Dne 29.5.2014 07:11, Masahiro Yamada napsal(a):
> > scripts/kconfig/zconf.l | 4 +--
> > scripts/kconfig/zconf.y | 2 +-
>
> Please also update the _shipped files.
Do you mean, fix the corresponding indents
in zconf.lex.c_shipped and zconf.tab.c_shipped by hand?
Or regenerate them with flex and bison?
I just tried:
flex -L -Pzconf -o scripts/kconfig/zconf.lex.c_shipped scripts/kconfig/zconf.l
bison -l -o scripts/kconfig/zconf.tab.c_shipped scripts/kconfig/zconf.y
(Correct?)
But it introduced much more diffs and I am hesitating to do it.
The current zconf.tab.c_shipped was generated by Bison 2.5.
But I am using Bison 3.0.2.
If I need to regenerate _shipped, it would be better to do it
in a separete patch.
Anyway, I think updating indents by hand would be easier and safer.
Please advise me.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-06-10 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 5:11 [PATCH] kbuild: trivial - use tabs for code indent where possible Masahiro Yamada
2014-06-09 21:59 ` Michal Marek
2014-06-10 1:53 ` Masahiro Yamada [this message]
2014-06-10 9:09 ` Michal Marek
2014-06-10 10:10 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610105308.95F4.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox