Re: [PATCH v2 5/5] kbuild: clean-up and bug fix of scripts/Makefile.host

[Masahiro Yamada <yamada.m@jp.panasonic.com>]

Hi Michal,



On Fri, 11 Jul 2014 15:46:44 +0200
Michal Marek <mmarek@suse.cz> wrote:

> On 2014-06-09 06:16, Masahiro Yamada wrote:
> > -# hostprogs-y := tools/build may have been specified. Retrieve directory
> > -host-objdirs := $(dir $(__hostprogs))
> > -# directory of .o files from prog-objs notation
> > -host-objdirs += $(dir $(foreach f,$(host-cmulti), $($(f)-objs)))
> > -# directory of .o files from prog-cxxobjs notation
> > -host-objdirs += $(dir $(foreach f,$(host-cxxmulti), $($(f)-cxxobjs)))
> > +# hostprogs-y := tools/build may have been specified.
> > +# Retrieve also directory of .o files from prog-objs or prog-cxxobjs notation
> > +host-objdirs := $(dir \
> > +	     $(foreach f, $(__hostprogs), $(f) $($(f)-objs) $($(f)-cxxobjs)))
> 
> You could also use the $(host-cobjs) and $(host-cxxobjs) variables
> defined earlier and write
> 
> host-objdirs := $(dir $(__hostprogs) $(host-cobjs) $(host-cxxobjs))
> 


Yup, this is much cleaner.
Fixed in v3.

Thanks!


Best Regards
Masahiro Yamada