Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

Bertrand Jacquin
2014-08-19T15:22:55Z

Hi,

D'ar meurzh 19 a viz Eost 2014 e 15 eur 17, « Andi Kleen » he deus skrivet :
> Bertrand Jacquin <beber@meleeweb.net> writes:
> >
> > +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed
> > +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP
> > +# or CONFIG_MODULE_COMPRESS_XZ.
> > +
> > +mod_compress_cmd = true
> > +ifdef CONFIG_MODULE_COMPRESS
> > + ifdef CONFIG_MODULE_COMPRESS_GZIP
> > + mod_compress_cmd = gzip -n -9
>
> Please don't use gzip -9. The gain is very small, but it can make
> the time to compress much longer. Just use plain gzip.
>
> I suspect it doesn't make sense either for xz.

I understand your concern about this, but does is make sense to not use
-9 when then following files use gzip or other compression tools with -9 :

arch/blackfin/Makefile:14:GZFLAGS := -9

arch/powerpc/boot/wrapper:297: gzip -n -f -9 "$vmz.$$"
arch/powerpc/boot/wrapper:422: gzip -n -f -9 "$ofile"
arch/powerpc/boot/wrapper:469: gzip -n --force -9 --stdout "$ofile.bin" > "$odir/otheros.bld"

arch/arm/Makefile:23:GZFLAGS :=-9
arch/arm64/Makefile:16:GZFLAGS :=-9

arch/m68k/Makefile:138: gzip -9c vmlinux.tmp >vmlinux.gz
arch/m68k/Makefile:141: gzip -9c vmlinux >vmlinux.gz

arch/mips/lasat/image/Makefile:46: gzip -cf -9 $< > $@

arch/parisc/Makefile:121: @gzip -cf -9 $< > $@

scripts/package/mkspec:115:echo 'bzip2 -9 vmlinux'
scripts/package/builddeb:20: gzip -9 "$pdir/usr/share/doc/$pname/changelog.Debian"
scripts/package/Makefile:127: -f -9 $(perf-tar).tar)

scripts/gen_initramfs_list.sh:229:compr="gzip -n -9 -f"
scripts/gen_initramfs_list.sh:245: && compr="gzip -n -9 -f"
scripts/gen_initramfs_list.sh:248: && compr="bzip2 -9 -f"
scripts/gen_initramfs_list.sh:251: && compr="lzma -9 -f"
scripts/gen_initramfs_list.sh:257: && compr="lzop -9 -f"
scripts/gen_initramfs_list.sh:260: && compr="lz4 -l -9 -f"

scripts/Makefile.lib:241:cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -n -f -9 > $@) || \
scripts/Makefile.lib:311: bzip2 -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
scripts/Makefile.lib:319: lzma -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
scripts/Makefile.lib:324: lzop -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \

--
Beber