From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.mei.co.jp ([133.183.100.20]:42518 "EHLO smtp.mei.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755604AbaHVB1P (ORCPT ); Thu, 21 Aug 2014 21:27:15 -0400 Date: Fri, 22 Aug 2014 10:27:01 +0900 From: Masahiro Yamada Subject: Re: [PATCH] kbuild: Make scripts executable In-Reply-To: <53F5BCC8.4060000@suse.cz> References: <20140821122521.2D67.AA925319@jp.panasonic.com> <53F5BCC8.4060000@suse.cz> Message-Id: <20140822102701.2D80.AA925319@jp.panasonic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Michal Marek Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Hi Michal, On Thu, 21 Aug 2014 11:32:56 +0200 Michal Marek wrote: > On 2014-08-21 05:25, Masahiro Yamada wrote: > > Hi Michal, > > > > > > On Wed, 20 Aug 2014 16:10:48 +0200 > > Michal Marek wrote: > > > >> The Makefiles call the respective interpreter explicitly, but this makes > >> it easier to use the scripts manually. > >> > >> Signed-off-by: Michal Marek > > > > > > I am not sure at all, but > > it seems scripts/checkpatch.pl has a rule > > to ban execute permissions. > > I didn't know about this, but the intent of the rule seems to be to > avoid *.c files with execute permissions. > > > > # Check for incorrect file permissions > > if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { > > my $permhere = $here . "FILE: $realfile\n"; > > if ($realfile !~ m@scripts/@ && > > $realfile !~ /\.(py|pl|awk|sh)$/) { > > Here it explicitly skips files below scripts/ and files with known > script suffixes. > OK then. I replied without understanding this code well. My appologies. Best Regards Masahiro Yamada