From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] kbuild: remove obj-n and lib-n handling
Date: Thu, 02 Oct 2014 22:17:54 +0900 [thread overview]
Message-ID: <20141002221754.3504.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <542D4D6C.9000505@suse.cz>
Hi Michal,
On Thu, 02 Oct 2014 15:04:44 +0200
Michal Marek <mmarek@suse.cz> wrote:
> On 2014-09-09 12:26, Masahiro Yamada wrote:
> > Kconfig never defines CONFIG_* as 'n'.
> > Now obj-n is only used in firmware/Makefile and it can be
> > replaced with obj-. No makefile uses lib-n.
>
> BTW, there are a few more instances of *-n, none of which seem useful:
>
> $ git --no-pager grep -e '[a-z]-n\>' -- '*Makefile*' '*Kbuild*'
> Makefile: $(init-n) $(init-) \
> Makefile: $(core-n) $(core-) $(drivers-n) $(drivers-) \
> Makefile: $(net-n) $(net-) $(libs-n) $(libs-))))
> arch/arm/mach-ixp4xx/Makefile:obj-pci-n :=
> arch/powerpc/boot/Makefile:initrd- := $(patsubst zImage%,
> zImage.initrd%, $(image-n) $(image-))
Uh, I missed them.
Anyway, it should be done in a separate patch
even if we fix them.
Can you fix them, please?
(I do not want to steal what you found.)
Simpler makefiles seem better.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-10-02 13:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 10:26 [PATCH 0/3] kbuild: Clean up makefiles and then drop obj-n an obj-n Masahiro Yamada
2014-09-09 10:26 ` [PATCH 1/3] kbuild: remove unnecessary "obj- := dummy.o" trick Masahiro Yamada
2014-09-09 16:21 ` Peter Foley
2014-09-09 17:43 ` Mike Turquette
2014-09-09 23:45 ` Simon Horman
2014-09-10 3:40 ` David Miller
2014-09-09 10:26 ` [PATCH 2/3] kbuild: remove unnecessary variable initializaions Masahiro Yamada
2014-09-09 11:52 ` Nicolas Ferre
2014-09-09 16:23 ` Peter Foley
2014-09-23 14:56 ` Linus Walleij
2014-09-09 10:26 ` [PATCH 3/3] kbuild: remove obj-n and lib-n handling Masahiro Yamada
2014-09-09 16:20 ` Peter Foley
2014-10-02 13:02 ` Michal Marek
2014-10-02 13:04 ` Michal Marek
2014-10-02 13:17 ` Masahiro Yamada [this message]
2014-10-02 13:33 ` [PATCH] kbuild: Do not reference *-n variables in the Makefile Michal Marek
2014-10-02 13:35 ` Michal Marek
2014-10-02 13:55 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002221754.3504.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox