From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: collect shorthands into the top Makefile
Date: Fri, 31 Oct 2014 11:12:55 +0900 [thread overview]
Message-ID: <20141031111254.8FF3.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20141029185907.GA701@ravnborg.org>
Hi Sam,
On Wed, 29 Oct 2014 19:59:07 +0100
Sam Ravnborg <sam@ravnborg.org> wrote:
> On Wed, Oct 29, 2014 at 04:27:31PM +0900, Masahiro Yamada wrote:
> > The motivation of this commit is to avoid duplicated definitions
> > of "clean" and "hdr-inst" shorthands.
> >
> > The shorthand "clean" is defined in both the top Makefile and
> > scripts/Makefile.clean.
> >
> > Likewise, "hdr-inst" is defined in both the top Makefile and
> > scripts/Makefile.headersinst.
> >
> > The idea here is define and export them in the top Makefile
> > because $(srctree) is constant during the build process.
> >
> > For consistency, "build" and "modbuiltin" should be also moved.
>
> As a general rule the exported names are always UPPERCASE, and local variables
> are lowercase. (srctree, objtree are the exceptions).
> This patch define new lowercase variables that conflicts with this.
>
> And it is not that logical these are picked up from the enviroment.
> Could you find a central place to define them rahter than using
> the environemnt to export them?
Maybe we can collect them into scripts/Kbuild.include
although it might be too much for Makefile.clean to include
the whole things in Kbuild.include.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-10-31 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 7:27 [PATCH] kbuild: collect shorthands into the top Makefile Masahiro Yamada
2014-10-29 18:59 ` Sam Ravnborg
2014-10-31 2:12 ` Masahiro Yamada [this message]
2014-11-25 21:23 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031111254.8FF3.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=ak@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox