From: Michal Marek <mmarek@suse.cz>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: collect shorthands into scripts/Kbuild.include
Date: Wed, 26 Nov 2014 14:55:08 +0100 [thread overview]
Message-ID: <20141126135508.GA6911@sepie.suse.cz> (raw)
In-Reply-To: <1416997873-3872-1-git-send-email-yamada.m@jp.panasonic.com>
On Wed, Nov 26, 2014 at 07:31:13PM +0900, Masahiro Yamada wrote:
> The shorthand "clean" is defined in both the top Makefile and
> scripts/Makefile.clean. Likewise, the "hdr-inst" is defined in
> both the top Makefile and scripts/Makefile.headersinst.
>
> To reduce code duplication, this commit collects them into
> scripts/Kbuild.include like the "build" and "modbuiltin" shorthands.
> It requires scripts/Makefile.clean to include scripts/Kbuild.include,
> but its impact on the performance of "make clean" should be
> negligible.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> Marek, please decide if this patch should be applied or not.
>
> I am not so sure if 10% of performance regression is acceptable.
> I do not mind at all if this patch is rejected.
>
> Before this commit, on my box,
>
> $ time make clean
>
> real 0m2.916s
> user 0m1.040s
> sys 0m2.005s
>
> After,
>
> real 0m3.221s
> user 0m1.109s
> sys 0m2.271s
0.3s is even less than my guess. And as I said, you can run make clean
in parallel, so I'm not thrilled. Applied to kbuild.git#kbuild.
Thanks,
Michal
prev parent reply other threads:[~2014-11-26 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 10:31 [PATCH] kbuild: collect shorthands into scripts/Kbuild.include Masahiro Yamada
2014-11-26 13:55 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126135508.GA6911@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=ak@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox