Re: [PATCH] kbuild: fix scripts/headers.sh to see the correct Kbuild path

Paul Bolle
2014-12-08T21:58:35Z

Masahiro,

On Wed, 2014-12-03 at 15:52 +0900, Masahiro Yamada wrote:
> The exported headers were moved to "uapi" directories.
> We should check the existence of arch/*/include/uapi/asm/Kbuild.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---

Does this patch fix any problems? If so, which? And why did no one
notice these problems before? Perhaps the commit explanation could
mention that.

See, none of this is obvious, at least to me, and I don't think people
reading the patch should be expected to figure this out themselves.

> scripts/headers.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/headers.sh b/scripts/headers.sh
> index 95ece06..b164336 100755
> --- a/scripts/headers.sh
> +++ b/scripts/headers.sh
> @@ -6,7 +6,7 @@ set -e
>
> do_command()
> {
> - if [ -f ${srctree}/arch/$2/include/asm/Kbuild ]; then
> + if [ -f ${srctree}/arch/$2/include/uapi/asm/Kbuild ]; then
> make ARCH=$2 KBUILD_HEADERS=$1 headers_$1
> else
> printf "Ignoring arch: %s\n" ${arch}

Thanks,

Paul Bolle