linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Michal Marek <mmarek@suse.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH 1/2] kbuild: add AFLAGS_REMOVE_(basename).o option
Date: Mon, 30 Nov 2015 09:52:51 +0100	[thread overview]
Message-ID: <20151130085251.GC4045@osiris> (raw)
In-Reply-To: <565C0A8D.2010900@suse.com>

On Mon, Nov 30, 2015 at 09:36:29AM +0100, Michal Marek wrote:
> >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> >> index 79e86613712f..26a48d76eb9d 100644
> >> --- a/scripts/Makefile.lib
> >> +++ b/scripts/Makefile.lib
> >> @@ -104,8 +104,9 @@ modname_flags  = $(if $(filter 1,$(words $(modname))),\
> >>  orig_c_flags   = $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS) $(KBUILD_SUBDIR_CCFLAGS) \
> >>                   $(ccflags-y) $(CFLAGS_$(basetarget).o)
> >>  _c_flags       = $(filter-out $(CFLAGS_REMOVE_$(basetarget).o), $(orig_c_flags))
> >> -_a_flags       = $(KBUILD_CPPFLAGS) $(KBUILD_AFLAGS) $(KBUILD_SUBDIR_ASFLAGS) \
> >> +orig_a_flags   = $(KBUILD_CPPFLAGS) $(KBUILD_AFLAGS) $(KBUILD_SUBDIR_ASFLAGS) \
> >>                   $(asflags-y) $(AFLAGS_$(basetarget).o)
> >> +_a_flags       = $(filter-out $(AFLAGS_REMOVE_$(basetarget).o), $(orig_a_flags))
> >>  _cpp_flags     = $(KBUILD_CPPFLAGS) $(cppflags-y) $(CPPFLAGS_$(@F))
> >>  
> >>  #
> > 
> > Hello Michal,
> > 
> > since I didn't hear anything from you, I'll simply add this to the s390 tree.
> > The patch should be trivial enough and is certainly not controversial.
> 
> Hi Heiko,
> 
> yes, please go ahead, the patch is fine.

Ok, thanks. I'll add your ack then.


  reply	other threads:[~2015-11-30  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21 10:59 [PATCH 0/2] kbuild: add AFLAGS_REMOVE Heiko Carstens
2015-11-21 10:59 ` [PATCH 1/2] kbuild: add AFLAGS_REMOVE_(basename).o option Heiko Carstens
2015-11-30  8:17   ` Heiko Carstens
2015-11-30  8:36     ` Michal Marek
2015-11-30  8:52       ` Heiko Carstens [this message]
2015-11-21 10:59 ` [PATCH 2/2] s390: compile head.s always with -march=z900 Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130085251.GC4045@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).