From: Richard Leitner <dev@g0hl1n.net>
To: yann.morin.1998@free.fr, linux-kbuild@vger.kernel.org
Subject: Re: menuconfig doesn't reset terminal colors correctly
Date: Mon, 28 Mar 2016 18:10:01 +0200 [thread overview]
Message-ID: <20160328181001.25852ea9@frodo> (raw)
In-Reply-To: <20160320123550.5331cfb6@frodo>
Hi,
any updates on this?
On Sun, 20 Mar 2016 12:35:50 +0100
Richard Leitner <dev@g0hl1n.net> wrote:
> Hello,
> I just noticed that "make menuconfig" doesn't reset the terminal
> colors correctly. I'm running a XFCE Terminal with "xterm" emulation
> setting and configured with black on white. After "make menuconfig"
> exits all terminal output is white on black.
>
> I've added fprintf's with the ANSI reset code for stdout and stderr
> to the mconf.c:handle_exit:
>
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -969,6 +969,10 @@ static int handle_exit(void)
>
> end_dialog(saved_x, saved_y);
>
> + /* reset terminal */
> + fprintf(stdout, "\033[0m");
> + fprintf(stderr, "\033[0m");
> +
> switch (res) {
> case 0:
> if (conf_write(filename)) {
>
>
> Basically this works for my tests, but I'm not sure if this is a
> desired solution... Any comments? Should I prepare a patch for that
> or is this approach completely wrong?
>
> thanks & regards,
> Richard
prev parent reply other threads:[~2016-03-28 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 11:35 menuconfig doesn't reset terminal colors correctly Richard Leitner
2016-03-28 16:10 ` Richard Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328181001.25852ea9@frodo \
--to=dev@g0hl1n.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox