From: "C.J. Collier KF7BMP" <cjcollier@linuxfoundation.org>
To: Michal Marek <mmarek@suse.com>, linux-kbuild@vger.kernel.org
Subject: Example 3 inclusion, Documentation/kbuild/modules.txt:250
Date: Sun, 3 Apr 2016 17:41:40 -0700 [thread overview]
Message-ID: <20160404004140.GA10001@linuxfoundation.org> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 371 bytes --]
Hello Michal and kbuild team,
I think I've spotted an error in the module KBuild / Makefile
documentation. I believe that the first condition should be executed
only if KERNELRELEASE is unset, and the rest should be executed
unconditionally. Let me know if I'm misreading it.
This patch is Copyright 2016 The Linux Foundation.
Cheers,
C.J. Collier
Release Engineer
[-- Attachment #1.2: modules.txt_20160403T145432-0800.diff.asc --]
[-- Type: text/plain, Size: 1594 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
diff --git a/Documentation/kbuild/modules.txt b/Documentation/kbuild/modules.txt
index 3fb39e0..1c79e82 100644
- --- a/Documentation/kbuild/modules.txt
+++ b/Documentation/kbuild/modules.txt
@@ -247,8 +247,8 @@ module 8123.ko, which is built from the following files:
ifneq ($(KERNELRELEASE),)
# kbuild part of makefile
include Kbuild
+ endif
- - else
# normal makefile
KDIR ?= /lib/modules/`uname -r`/build
@@ -259,7 +259,6 @@ module 8123.ko, which is built from the following files:
genbin:
echo "X" > 8123_bin.o_shipped
- - endif
Here the "Kbuild" file is included from the makefile. This
allows an older version of kbuild, which only knows of
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCgAGBQJXAZCwAAoJEMDbis1LPFKZc6wQAKezPVsxhhIoAZCcyiKNRtnR
pfiwP4Xv770zA+bHU9OplMNr6uGRUqLfnub5X5dNTawiUWS0AuKp8JiOFdXA2jJf
gHsq2PGM9+qsV4JWVQ1Qf9sZo1g9gHDO+c9OJNRR0YYk6pqY1vX8/hksXT7mjZmr
g4JcPyqf9W0wtzt5yL9mdBforU1b+5/5K9Im1JYZoilgcEW7ZlbVhes6p3PcYbGn
+5/8DIvzRcGheyMqh12NQ2D6DckTqZWl5yNAJK+N7iWfD3VdPB/R6ZVcYC7NGiuf
ZQMDi59KKSf5tXXLcQnTSt/kB7yRRuM2TYpV6UvlTFV73VVLFrP17YjmirvYovKJ
EQ1s8d1JXgRmh6BWX9sONtd6DuhFk99C2g2vpoTTn2lc0f1FAfICMIAiLd+FonL/
2lPiQVBbNavKbz137lVUUtJ2rKWHyM9l/Zz1gbpHvtkvIYaKqajoZUGQmTS3RHSC
55bb8Y+13/fkmRCBRsAnEtS3Do/OPRd0+6Keed0FhsKYG/BlWtRUs7NSb2uehKu0
Qge+QT3mZgpPI2pjm0tm+98Afb6DYOpS8m5zY7MV7xof4ZAJRsvPwrIOKDyJfvDx
1LRw/CxAUK8d+RN6hpWdU2q1oHoWTxoQYXDgRu0ikiOMmAunbxNEFuGfCd7Q0ils
4ksi0j2Hv+qx4PsgKCXl
=ffMV
-----END PGP SIGNATURE-----
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next reply other threads:[~2016-04-04 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 0:41 C.J. Collier KF7BMP [this message]
2016-04-04 19:21 ` Example 3 inclusion, Documentation/kbuild/modules.txt:250 Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404004140.GA10001@linuxfoundation.org \
--to=cjcollier@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).