From: Emese Revfy <re.emese@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
PaX Team <pageexec@freemail.hu>,
Brad Spengler <spender@grsecurity.net>,
kernel-hardening@lists.openwall.com,
Michal Marek <mmarek@suse.com>, Kees Cook <keescook@chromium.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Fengguang Wu <fengguang.wu@intel.com>,
Dmitry Vyukov <dvyukov@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Brown <david.brown@linaro.org>
Subject: Re: [PATCH v7 1/6] Shared library support
Date: Mon, 2 May 2016 19:56:17 +0200 [thread overview]
Message-ID: <20160502195617.9b2b7e07ced214a8f2136364@gmail.com> (raw)
In-Reply-To: <CAK7LNAR-+4+Xdhbs6hoPUTYppLqFwY8dxqdSuw_5j6Pge4uYVg@mail.gmail.com>
On Mon, 2 May 2016 14:03:00 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> In the first place,
> I am wondering if we need to revive this documentation.
> What this commit is only interested in *.so generation,
> not host program support.
I agree that we don't need this documentation. I'll remove it.
> > @@ -124,5 +158,39 @@ quiet_cmd_host-cxxobjs = HOSTCXX $@
> > $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
> > $(call if_changed_dep,host-cxxobjs)
> >
> > +# Compile .c file, create position independent .o file
> > +# host-cshobjs -> .o
> > +quiet_cmd_host-cshobjs = HOSTCC -fPIC $@
> > + cmd_host-cshobjs = $(HOSTCC) $(hostc_flags) -fPIC -c -o $@ $<
> > +$(host-cshobjs): $(obj)/%.o: $(src)/%.c FORCE
> > + $(call if_changed_dep,host-cshobjs)
> > +
> > +# Compile .c file, create position independent .o file
>
>
> Please explain why c++ compiler should be used to compile .c files.
>
> This is not clear, so worth commenting.
Where do you think that the C++ compiler is used above? I think HOSTCC can only be C compiler.
--
Emese
next prev parent reply other threads:[~2016-05-02 17:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 18:19 [PATCH v7 0/6] Introduce GCC plugin infrastructure Emese Revfy
2016-04-22 18:21 ` [PATCH v7 1/6] Shared library support Emese Revfy
2016-05-02 5:03 ` Masahiro Yamada
2016-05-02 17:56 ` Emese Revfy [this message]
2016-05-03 2:00 ` Masahiro Yamada
2016-05-03 21:29 ` Emese Revfy
2016-05-04 4:09 ` Masahiro Yamada
2016-05-05 18:40 ` Emese Revfy
2016-05-03 2:06 ` Masahiro Yamada
2016-05-03 21:25 ` Emese Revfy
2016-05-05 18:43 ` Emese Revfy
2016-04-22 18:22 ` [PATCH v7 2/6] GCC plugin infrastructure Emese Revfy
2016-05-02 5:07 ` Masahiro Yamada
2016-05-02 17:59 ` [kernel-hardening] " Emese Revfy
2016-05-11 11:24 ` Michal Marek
2016-05-12 15:04 ` Emese Revfy
2016-04-22 18:23 ` [PATCH v7 3/6] The GCC plugin infrastructure supports the arm and arm64 architectures too Emese Revfy
2016-05-02 5:08 ` Masahiro Yamada
2016-04-22 18:24 ` [PATCH v7 4/6] Add Cyclomatic complexity GCC plugin Emese Revfy
2016-05-02 5:09 ` Masahiro Yamada
2016-04-22 18:26 ` [PATCH v7 5/6] Documentation for the GCC plugin infrastructure Emese Revfy
2016-05-02 5:10 ` Masahiro Yamada
2016-05-02 18:07 ` Emese Revfy
2016-04-22 18:27 ` [PATCH v7 6/6] Add sancov plugin Emese Revfy
2016-04-22 18:51 ` Dmitry Vyukov
2016-04-26 20:40 ` [PATCH v7 0/6] Introduce GCC plugin infrastructure Kees Cook
2016-04-27 1:40 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502195617.9b2b7e07ced214a8f2136364@gmail.com \
--to=re.emese@gmail.com \
--cc=david.brown@linaro.org \
--cc=dvyukov@google.com \
--cc=fengguang.wu@intel.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mmarek@suse.com \
--cc=pageexec@freemail.hu \
--cc=spender@grsecurity.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox