From: Michal Marek <mmarek@suse.cz>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: forbid kernel directory to contain spaces and colons
Date: Tue, 10 May 2016 17:05:55 +0200 [thread overview]
Message-ID: <20160510150554.GA30705@pobox.suse.cz> (raw)
In-Reply-To: <1459625933-20677-1-git-send-email-robert.jarzmik@free.fr>
On Sat, Apr 02, 2016 at 09:38:53PM +0200, Robert Jarzmik wrote:
> When the kernel path contains a space or a colon somewhere in the path
> name, the modules_install target doesn't work anymore, as the path names
> are not enclosed in double quotes. It is also supposed that and O= build
> will suffer from the same weakness as modules_install.
>
> Instead of checking and improving kbuild to resist to directories
> including these characters, error out early to prevent any build if the
> kernel's main directory contains a space.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v1: add colon check as requested by Michal.
> ---
> Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to kbuild.git#kbuild.
Michal
prev parent reply other threads:[~2016-05-10 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 19:38 [PATCH v2] kbuild: forbid kernel directory to contain spaces and colons Robert Jarzmik
2016-05-10 15:05 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510150554.GA30705@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox