From: Eugeniu Rosca <eugeniu.m.rosca@gmail.com>
To: Michal Marek <mmarek@suse.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts/tags.sh: Exit gracefully if *tags tool not found
Date: Sun, 15 May 2016 15:44:13 +0200 [thread overview]
Message-ID: <20160515134413.GA14628@eugeniu-X230> (raw)
In-Reply-To: <571E0F1F.8090204@suse.com>
On Mon, Apr 25, 2016 at 02:35:43PM +0200, Michal Marek wrote:
> On 2016-04-24 18:42, Eugeniu Rosca wrote:
> > If the needed host utility is not found, current behavior is:
> >
> > $> make cscope
> > GEN cscope
> > ./scripts/tags.sh: line 140: cscope: command not found
> > $> make gtags
> > GEN gtags
> > ./scripts/tags.sh: line 145: gtags: command not found
> > $> make tags
> > GEN tags
> > xargs: ctags: No such file or directory
> > sed: can't read tags: No such file or directory
> > Makefile:1509: recipe for target 'tags' failed
> > make: *** [tags] Error 2
> > $> make TAGS
> > GEN TAGS
> > xargs: etags: No such file or directory
> > sed: can't read TAGS: No such file or directory
> > Makefile:1509: recipe for target 'TAGS' failed
> > make: *** [TAGS] Error 2
> >
> > This patch allows to exit gracefully in such a situation:
> >
> > $> make cscope
> > GEN cscope
> > cscope - not installed?
> > $> make gtags
> > GEN gtags
> > gtags - not installed?
> > $> make tags
> > GEN tags
> > ctags - not installed?
> > $> make TAGS
> > GEN TAGS
> > etags - not installed?
>
> It should fail if it's unable to create the requested file, though.
> Appending '|| exit' to the docscope/dogtags/xtags calls should suffice.
>
> Michal
Hi Michal,
Late feedback from my end...
I would kindly ask you to select one of the options provided below:
OPTION 1: Append '|| exit' to the docscope/dogtags/xtags calls.
RESULT: This produces more error messages than with the original script:
$> make cscope
GEN cscope
./scripts/tags.sh: line 140: cscope: command not found
Makefile:1517: recipe for target 'cscope' failed
make: *** [cscope] Error 127
$> make gtags
GEN gtags
./scripts/tags.sh: line 145: gtags: command not found
Makefile:1517: recipe for target 'gtags' failed
make: *** [gtags] Error 127
$> make tags
GEN tags
xargs: ctags: No such file or directory
Makefile:1517: recipe for target 'tags' failed
make: *** [tags] Error 127
$> make TAGS
GEN TAGS
xargs: etags: No such file or directory
Makefile:1517: recipe for target 'TAGS' failed
make: *** [TAGS] Error 127
$>
OPTION 2: Append '|| exit 0' to the docscope/dogtags/xtags calls.
RESULT: Cleaner output, but still without suggesting the root-cause:
$> make cscope
GEN cscope
./scripts/tags.sh: line 140: cscope: command not found
$> make gtags
GEN gtags
./scripts/tags.sh: line 145: gtags: command not found
$> make tags
GEN tags
xargs: ctags: No such file or directory
$> make TAGS
GEN TAGS
xargs: etags: No such file or directory
$>
OPTION 3: Initial patch.
RESULT: Cleaner output, but maybe putting too much infrastructure for
checking against missing utilities?
$> make cscope
GEN cscope
cscope - not installed?
$> make gtags
GEN gtags
gtags - not installed?
$> make tags
GEN tags
ctags - not installed?
$> make TAGS
GEN TAGS
etags - not installed?
OPTION 4: Something else?
RESULT: ?
Best regards,
Eugeniu.
next prev parent reply other threads:[~2016-05-15 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 16:42 [PATCH] scripts/tags.sh: Exit gracefully if *tags tool not found Eugeniu Rosca
2016-04-25 12:35 ` Michal Marek
2016-05-15 13:44 ` Eugeniu Rosca [this message]
2016-05-16 7:06 ` Michal Marek
2016-05-16 13:37 ` [PATCH v2] scripts/tags.sh: Handle missing {c,e,g}tags/cscope utilities Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160515134413.GA14628@eugeniu-X230 \
--to=eugeniu.m.rosca@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox