public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: setlocalversion: print error to STDERR
Date: Mon, 20 Jun 2016 17:38:45 +0200	[thread overview]
Message-ID: <20160620153845.GA11949@sepie.suse.cz> (raw)
In-Reply-To: <1465239638-20314-1-git-send-email-wsa@the-dreams.de>

On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote:
> I tried to use 'make O=...' from an unclean source tree. This triggered
> the error path of setlocalversion. But by printing to STDOUT, it created
> a broken localversion which then caused another (unrelated) error:
> 
> "4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters
> 
> After printing to STDERR, the true build error gets displayed later:
> 
>   /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
>   in the '/home/wsa/Kernel/linux' directory.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  scripts/setlocalversion | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to kbuild.git#kbuild. But this points at another
problem, namely that filechk is ignoring the exit status of the command.

Michal

      reply	other threads:[~2016-06-20 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06 19:00 [PATCH] kbuild: setlocalversion: print error to STDERR Wolfram Sang
2016-06-20 15:38 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620153845.GA11949@sepie.suse.cz \
    --to=mmarek@suse.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox