Re: [PATCH v1 2/2] Mark functions with the __nocapture attribute

PaX Team
2016-06-28T21:40:28Z

On 28 Jun 2016 at 22:50, Rasmus Villemoes wrote:

> > +extern const char *kstrdup_const(const char *s, gfp_t gfp) __nocapture(1);
>
> OK, so this one is pretty dangerous, and probably wrong. If one does
>
> foo->bar = kstrdup_const(a-macro-that-might-be-a-string-literal)
>
> in an .init function, foo->bar will very likely become dangling.

doesn't kstrdup_const omit the copy only for arguments that are stored in
.rodata (which doesn't include .init.rodata* and other init sections)?

cheers,
PaX Team