* [PATCH 1/2] xconfig: fix 'Show Debug' functionality
@ 2016-11-30 22:57 Randy Dunlap
2016-12-11 20:42 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2016-11-30 22:57 UTC (permalink / raw)
To: linux-kbuild, Michal Marek; +Cc: Jason Vas Dias, Boris Barbulovski
From: Boris Barbulovski <bbarbulovski@gmail.com>
xconfig - Fix missing 'Show Debug' functionality.
xconfig Help mentions 'Show Debug Info' but it was missing from any
menu.
* Add 'Show debug' menu to the main menu.
* Properly load showDebug settings.
Reported-by: Jason Vas Dias <jason.vas.dias@gmail.com>
Signed-off-by: Boris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
---
scripts/kconfig/qconf.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Boris asked me to push these 2 patches.
--- lnx-49-rc7.orig/scripts/kconfig/qconf.cc
+++ lnx-49-rc7/scripts/kconfig/qconf.cc
@@ -1014,7 +1014,7 @@ ConfigInfoView::ConfigInfoView(QWidget*
if (!objectName().isEmpty()) {
configSettings->beginGroup(objectName());
- _showDebug = configSettings->value("/showDebug", false).toBool();
+ setShowDebug(configSettings->value("/showDebug", false).toBool());
configSettings->endGroup();
connect(configApp, SIGNAL(aboutToQuit()), SLOT(saveSettings()));
}
@@ -1474,6 +1474,7 @@ ConfigMainWindow::ConfigMainWindow(void)
optionMenu->addSeparator();
optionMenu->addActions(optGroup->actions());
optionMenu->addSeparator();
+ optionMenu->addAction(showDebugAction);
// create help menu
menu->addSeparator();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] xconfig: fix 'Show Debug' functionality
2016-11-30 22:57 [PATCH 1/2] xconfig: fix 'Show Debug' functionality Randy Dunlap
@ 2016-12-11 20:42 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2016-12-11 20:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kbuild, Michal Marek, Jason Vas Dias, Boris Barbulovski
On Wed, Nov 30, 2016 at 02:57:52PM -0800, Randy Dunlap wrote:
> From: Boris Barbulovski <bbarbulovski@gmail.com>
>
> xconfig - Fix missing 'Show Debug' functionality.
>
> xconfig Help mentions 'Show Debug Info' but it was missing from any
> menu.
>
> * Add 'Show debug' menu to the main menu.
> * Properly load showDebug settings.
>
> Reported-by: Jason Vas Dias <jason.vas.dias@gmail.com>
> Signed-off-by: Boris Barbulovski <bbarbulovski@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Applied to kbuild.git#kconfig.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-11 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 22:57 [PATCH 1/2] xconfig: fix 'Show Debug' functionality Randy Dunlap
2016-12-11 20:42 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).